>Number:         19566
>Category:       pkg
>Synopsis:       comms/xisp assumes dialer group exists (patch included)
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 26 05:12:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6
>Organization:
http://bsd.reedmedia.net/
>Environment:
	
	
System: NetBSD rainier.reedmedia.net 1.6 NetBSD 1.6 (JCR-20020927) #3: Sat Sep 28 13:40:20 PDT 2002 reed@rainier.reedmedia.net:/usr/src/sys/arch/i386/compile/JCR-20020927 i386
Architecture: i386
Machine: i386
>Description:
comms/xisp should build on systems without dialer group.
>How-To-Repeat:
install comms/xisp on system without dialer group and it will fail.
>Fix:
This patch implements a DIALER_GROUP (maybe it should be called
MODEM_GROUP) in mk/bsd.pkg.defaults.mk. Later this should be used for 
comms/hylafax, comms/minicom, and the net/ppp package I need to submit.

This patch also takes advantage of this new group for comms/xisp.

--- mk/bsd.pkg.defaults.mk.orig	Fri Dec 20 18:07:27 2002
+++ mk/bsd.pkg.defaults.mk	Thu Dec 26 04:50:19 2002
@@ -564,6 +564,13 @@
 # Possible: YES, NO
 # Default: NO
 
+DIALER_GROUP?=	dialer
+# Used in the xisp package to specify the default group for the
+# xisp binaries. Also the modem device and pppd and chat should
+# have access permissions by this group.
+# Possible: dialer, dip, uucp, root, dialout, or any other group
+# Default: dialer
+
 DT_LAYOUT?= US
 # Used by dt package to specify the keyboard layout.
 # Possible: US, FI, FR, GER, DV
--- comms/xisp/patches/patch-aa.orig	Thu Dec 26 04:38:14 2002
+++ comms/xisp/patches/patch-aa	Thu Dec 26 04:39:02 2002
@@ -94,7 +94,7 @@
 -#INSTALL    = /usr/bin/install
 +INSTPPPDIR = $(PREFIX)/share/examples/xisp
 +DESTDIR    = 
-+GROUP      = dialer
++GROUP      = $(DIALER_GROUP)
 +GCCFLAGS   = -Wall -O
 +EXTRADEFS  = -DMODEM_DEVICE=\"$(MODEM_PATH)\" -DHAVE_STRERROR
 +EXTRALIBS  = -lcrypt
--- comms/xisp/Makefile.orig	Wed Dec 25 12:07:05 2002
+++ comms/xisp/Makefile	Thu Dec 26 05:03:15 2002
@@ -12,6 +12,14 @@
 HOMEPAGE=		http://xisp.hellug.gr/
 COMMENT=		User-friendly X11 interface to pppd/chat
 
+DIALER_GROUP?=		dialer
+PKG_GROUPS=		${DIALER_GROUP}
+BUILD_DEFS+=		DIALER_GROUP
+
+MESSAGE_SUBST+=		DIALER_GROUP=${DIALER_GROUP}
+
+MAKE_ENV+=		DIALER_GROUP="${DIALER_GROUP}"
+
 USE_BUILDLINK2=		YES
 USE_X11BASE=		YES
 
@@ -24,4 +32,5 @@
 .include "../../graphics/xpm/buildlink2.mk"
 .include "../../x11/xforms/buildlink2.mk"
 
+.include "../../mk/bsd.pkg.install.mk"
 .include "../../mk/bsd.pkg.mk"
--- comms/xisp/MESSAGE.orig	Thu Dec 26 04:50:43 2002
+++ comms/xisp/MESSAGE	Thu Dec 26 04:51:41 2002
@@ -11,7 +11,7 @@
         ${X11BASE}/share/examples/xisp/peers/xisp_modem   to /etc/ppp/peers
         ${X11BASE}/share/examples/xisp/peers/xisp_dialer  to /etc/ppp/peers
 
-and make sure the file ownerships are set for user "root" and group "dialer"
-to be able to fully use this package.
+and make sure the file ownerships are set for user "root" and group
+"${DIALER_GROUP}" to be able to fully use this package.
 
 ===========================================================================
--- comms/xisp/distinfo.orig	Thu Dec 26 04:57:40 2002
+++ comms/xisp/distinfo	Thu Dec 26 04:57:47 2002
@@ -2,4 +2,4 @@
 
 SHA1 (xisp-2.6p1.tar.gz) = 5e6f1795f20b22fd26212215b86b505e00d43b9e
 Size (xisp-2.6p1.tar.gz) = 260645 bytes
-SHA1 (patch-aa) = 73d3a226124082f9f98e616e8b0bf1b7d8f26f04
+SHA1 (patch-aa) = c1a0de28a48d94412024c15fcf5a71effccc6268
>Release-Note:
>Audit-Trail:
>Unformatted: