Subject: kern/19795: net_osdep.h is lying.
To: None <gnats-bugs@gnats.netbsd.org>
From: None <joelw@unix.se>
List: netbsd-bugs
Date: 01/11/2003 12:06:24
>Number:         19795
>Category:       kern
>Synopsis:       net_osdep.h is lying.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 11 12:07:00 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Joel Wilsson
>Release:        NetBSD-current 1.6L
>Organization:
>Environment:
NetBSD sii.home 1.6L NetBSD 1.6L (NANASE) #0: Wed Jan  8 19:37:39 CET 2003     joelw@sii.home:/home/joelw/build/netbsd/sys/arch/i386/compile/NANASE i386
>Description:
NetBSD's and OpenBSD's ip_input functions have changed, but the
compatibility table in net_osdep.h has not been updated to reflect this.

Since revision 1.155 of ip_input.c we no longer byteswap ip_len or ip_off
in ip_input(); OpenBSD doesn't byteswap ip_id since revision 1.80 of
their ip_input.c. Update the compatibility table to reflect this.
While here, remove trailing whitespace from the freebsd[23] row.
>How-To-Repeat:
N/A
>Fix:
Index: sys/net/net_osdep.h
===================================================================
RCS file: /home/joelw/localrep/netbsd/sys/net/net_osdep.h,v
retrieving revision 1.1
retrieving revision 1.4
diff -u -r1.1 -r1.4
--- sys/net/net_osdep.h 7 Jan 2003 16:30:01 -0000       1.1
+++ sys/net/net_osdep.h 11 Jan 2003 19:48:59 -0000      1.4
@@ -49,10 +49,10 @@
  *             ip_len ip_id ip_off
  * bsdi3:          xs     x      x
  * bsdi4:          xs            x
- * freebsd[23]:    xs     x      x 
+ * freebsd[23]:    xs     x      x
  * freebsd4:       xs            x
- * NetBSD:          x            x
- * OpenBSD:        xs     x      x
+ * NetBSD:
+ * OpenBSD:        xs            x
  *
  * - ifa_ifwithaf()
  *   bsdi[34], netbsd, and openbsd define it in sys/net/if.c
>Release-Note:
>Audit-Trail:
>Unformatted: