Subject: pkg/19821: net/tcptrace doesn't compile on -current
To: None <gnats-bugs@gnats.netbsd.org>
From: None <wolfgang@wsrcc.com>
List: netbsd-bugs
Date: 01/12/2003 11:22:26
>Number:         19821
>Category:       pkg
>Synopsis:       net/tcptrace doesn't compile on -current
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 12 11:23:00 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Wolfgang S. Rupprecht
>Release:        NetBSD 1.6L
>Organization:
W S Rupprecht Computer Consulting, Fremont CA
>Environment:
	
	
System: NetBSD capsicum.wsrcc.com 1.6L NetBSD 1.6L (WSRCC_ATHLON) #23: Sat Jan 11 12:02:47 PST 2003 wolfgang@capsicum.wsrcc.com:/v/src/netbsd/src/sys/arch/i386/compile/WSRCC_ATHLON i386
Architecture: i386
Machine: i386
>Description:
	tcptrace doesn't compile on current.
>How-To-Repeat:
	cd /usr/pkgsrc/net/tcptrace ; make 
>Fix:

Rip out some code marked as a "portability fix".

"cvs diff -uN" doesn't seem to want to include the new files.  Here is
a shar instead.  cvs diff of distinfo at end.

# This is a shell archive.  Save it in a file, remove anything before
# this line, and then unpack it by entering "sh file".  Note, it may
# create directories; files and directories will be owned by you and
# have default permissions.
#
# This archive contains:
#
#	patches/patch-ab
#	patches/patch-ac
#
echo x - patches/patch-ab
sed 's/^X//' >patches/patch-ab << 'END-of-patches/patch-ab'
X+++ print.c	Sun Jan 12 11:02:48 2003
X@@ -707,6 +707,11 @@
X /* Lots of machines HAVE this, but they give slightly different formats */
X /* and it messes up my cross-platform testing.  I'll just do it the */
X /* "one true" way!  :-)  */
X+
X+/* 
X+
X+No, you did it in a non-compatible way. gone. -wsr
X+
X char *
X ether_ntoa (struct ether_addr *e)
X {
X@@ -718,3 +723,5 @@
X 	    pe[0], pe[1], pe[2], pe[3], pe[4], pe[5]);
X     return(buf);
X }
X+
X+*/
END-of-patches/patch-ab
echo x - patches/patch-ac
sed 's/^X//' >patches/patch-ac << 'END-of-patches/patch-ac'
X+++ tcptrace.h	Sun Jan 12 11:03:00 2003
X@@ -484,10 +484,17 @@
X 
X 
X /* external routine decls */
X+/* 
X+ * Why do folks do crap like this???  Use the system's 'include files! -wsr
X double sqrt(double x);
X char *ether_ntoa(struct ether_addr *e);
X void free(void *);
X int finite(double);
X+*/
X+
X+#include <math.h>
X+#include <stdlib.h>
X+
X 
X 
X /* global routine decls */
END-of-patches/patch-ac
exit

	
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/net/tcptrace/distinfo,v
retrieving revision 1.2
diff -u -r1.2 distinfo
--- distinfo	2001/04/21 11:23:36	1.2
+++ distinfo	2003/01/12 19:11:11
@@ -3,3 +3,5 @@
 SHA1 (tcptrace.5.2.1.tar.gz) = 838f81a2f5537631c16af6ca49b69863f43d2bd3
 Size (tcptrace.5.2.1.tar.gz) = 1178005 bytes
 SHA1 (patch-aa) = b338e2dada6cb3b1fee66d8d28b909cc5e6858fc
+SHA1 (patch-ab) = b478d09a09dca230ff9d1517b56334e871babd01
+SHA1 (patch-ac) = b8417c027c8e48403d28982b49e05dfb57013c7d

>Release-Note:
>Audit-Trail:
>Unformatted: