Subject: kern/20195: The ste driver (Dlink DFE-580TX) is broken, full-sized VLAN tagged frames cannot be recieved.
To: None <gnats-bugs@gnats.netbsd.org>
From: None <esben.norby@dxd.ericsson.se>
List: netbsd-bugs
Date: 02/03/2003 23:32:34
>Number:         20195
>Category:       kern
>Synopsis:       The ste driver (Dlink DFE-580TX) is broken, full-sized VLAN tagged frames cannot be recieved.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 03 23:33:00 PST 2003
>Closed-Date:
>Last-Modified:
>Originator:     Esben Norby
>Release:        1.6-stable
>Organization:
>Environment:
NetBSD NE0104 1.6_STABLE NetBSD 1.6_STABLE (ROUTER) #11: Mon Jan 20 16:46:15 CET 2003     root@NETBSDBUILDER:/src/sys/arch/i386/compile/ROUTER i386
>Description:
When using D-Link quad network cards (DFE-580-TX) and VLAN, it is not possible to recieve full-size VLAN tagged frames. The MAC must be told to allow normal frames + VLAN tag to pass. Don't know if this is a problem with other cards using the same driver.

(PS. I know the constant + 4 sucks (see patch), but i couldn't find a constant)
>How-To-Repeat:
Setup a VLAN tagged interface and ping with big packets. The answer should not be recieved.
>Fix:
--- if_ste.c.org	Thu Jan 16 14:49:57 2003
+++ if_ste.c	Thu Jan 16 14:49:09 2003
@@ -1260,6 +1260,9 @@
 	/* Set the FIFO release threshold to 512 bytes. */
 	bus_space_write_1(st, sh, STE_TxReleaseThresh, 512 >> 4);
 
+	/* allow VLAN tagged frames to pass */
+ 	bus_space_write_2(st, sh, STE_MaxFrameSize, ETHER_MAX_LEN + 4);
+
 	/*
 	 * Initialize the interrupt mask.
 	 */ 
>Release-Note:
>Audit-Trail:
>Unformatted: