>Number:         21656
>Category:       pkg
>Synopsis:       pkgsrc/wm/golem/Makefile should use "CFLAGS+=", not "CFLAGS="
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 23 07:52:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Toru TAKAMIZU
>Release:        NetBSD 1.6.1_STABLE
>Organization:
>Environment:
System: NetBSD localhost 1.6.1_STABLE NetBSD 1.6.1_STABLE (MIWA) #27: Mon Apr 28 18:45:35 JST 2003 toru@localhost:/usr/src/sys/arch/i386/compile/MIWA i386
Architecture: i386
Machine: i386
>Description:
Unless you have a good reason to use "CFLAGS=", you have to use
"CFLAGS+=" (with `+'). Am I right?
>How-To-Repeat:
Under pkgsrc/wm/golem, type "make".
>Fix:
Add `+'.

Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/wm/golem/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	2003/05/18 21:09:07	1.2
+++ Makefile	2003/05/23 07:50:27
@@ -33,7 +33,7 @@
 PLIST_SUBST=		NOT_SOUND="@comment "
 .endif
 
-CFLAGS=		-DPKG_SYSCONFDIR=\"\\\"${PKG_SYSCONFDIR}\\\"\"
+CFLAGS+=		-DPKG_SYSCONFDIR=\"\\\"${PKG_SYSCONFDIR}\\\"\"
 
 EGDIR=		${PREFIX}/share/examples/golem
 CONF_FILES=	${EGDIR}/golemrc.default ${PKG_SYSCONFDIR}/golemrc
>Release-Note:
>Audit-Trail:
>Unformatted: