Subject: misc/22283: TOOLS_* make vars not always defined when USETOOLS=never
To: None <gnats-bugs@gnats.netbsd.org>
From: Anders Hjalmarsson <hjalmar@hjalmar.to>
List: netbsd-bugs
Date: 07/27/2003 16:38:16
>Number: 22283
>Category: misc
>Synopsis: TOOLS_* make vars not always defined when USETOOLS=never
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: misc-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Jul 27 14:13:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator: Anders Hjalmarsson
>Release: NetBSD 1.6U
>Organization:
>Environment:
System: NetBSD bigbox.hjalmar.to 1.6U NetBSD 1.6U (BIGBOX-$Revision: 1.25 $) #228: Mon Jul 21 23:05:34 CEST 2003 hjalmar@bigbox.hjalmar.to:/usr/SRC/config/i386/compile/BIGBOX i386
Architecture: i386
Machine: i386
Userland current from 20030727
>Description:
make obj and make build do not work properly when
USETOOLS=never because the TOOL_* variables are only defined by
bsd.sys.mk in that case. (When USETOOLS=yes they are defined in
bsd.own.mk) Not all bsd.*.mk files, which are included standalone
by at least some makefiles, include bsd.sys.mk
>How-To-Repeat:
Set USETOOLS=never in /etc/mk.conf and do a make obj or a make
build in /usr/src
The problem is that TOOL_STAT is not defined.
Small excerpt from output of make obj:
obj ===> regress/sys/kern/umount
-qf: not found
>Fix:
The following patch fixes the problem.
Index: bsd.kinc.mk
===================================================================
RCS file: /cvsroot/src/share/mk/bsd.kinc.mk,v
retrieving revision 1.27
diff -u -r1.27 bsd.kinc.mk
--- bsd.kinc.mk 2003/07/20 15:02:10 1.27
+++ bsd.kinc.mk 2003/07/27 13:50:04
@@ -79,3 +79,4 @@
##### Pull in related .mk logic
.include <bsd.subdir.mk>
+.include <bsd.sys.mk>
Index: bsd.obj.mk
===================================================================
RCS file: /cvsroot/src/share/mk/bsd.obj.mk,v
retrieving revision 1.42
diff -u -r1.42 bsd.obj.mk
--- bsd.obj.mk 2003/07/20 15:02:11 1.42
+++ bsd.obj.mk 2003/07/27 13:50:04
@@ -100,4 +100,6 @@
print-objdir:
@echo ${.OBJDIR}
+
+.include <bsd.sys.mk>
.endif
>Release-Note:
>Audit-Trail:
>Unformatted: