Subject: pkg/22531: security/tcp_wrappers doesn't build on systems without a 'make' binary
To: None <gnats-bugs@gnats.netbsd.org>
From: None <soren@bob.blef.org>
List: netbsd-bugs
Date: 08/18/2003 12:23:50
>Number: 22531
>Category: pkg
>Synopsis: security/tcp_wrappers doesn't build on systems without a 'make' binary
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Aug 18 19:24:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator: Soren Jacobsen
>Release: NetBSD 1.6.1
>Organization:
>Environment:
Debian GNU/Linux with 'make' deb removed
pkgsrc as of 08/18/2003.
>Description:
tcp_wrappers' Makefile calls 'make' when it should be using ${MAKE_PROGRAM}.
Problem reported by Jeremy C. Reed on tech-pkg@ in response to pkg/22506.
>How-To-Repeat:
Install on a system with only a bmake binary.
>Fix:
For some reason, MAKE_PROGRAM is empty in tcp_wrappers' Makefile, but MAKE
works fine.
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/security/tcp_wrappers/distinfo,v
retrieving revision 1.4
diff -u -r1.4 distinfo
--- distinfo 2003/06/10 17:58:34 1.4
+++ distinfo 2003/08/18 19:07:33
@@ -2,4 +2,4 @@
SHA1 (tcp_wrappers_7.6-ipv6.1.tar.gz) = d0b70d4f0c0ac0375d8283a18ec2b6d602f82fde
Size (tcp_wrappers_7.6-ipv6.1.tar.gz) = 144708 bytes
-SHA1 (patch-aa) = 4158e67803e39d9cf0469bc1961ea2a1e6d672e2
+SHA1 (patch-aa) = e2a1a9638842ae97f1c6cd734656fc0153e70d11
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/security/tcp_wrappers/patches/patch-aa,v
retrieving revision 1.5
diff -u -r1.5 patch-aa
--- patches/patch-aa 2003/06/10 17:58:34 1.5
+++ patches/patch-aa 2003/08/18 19:07:33
@@ -1,7 +1,7 @@
-$NetBSD: patch-aa,v 1.5 2003/06/10 17:58:34 jschauma Exp $
+$NetBSD$
--- Makefile.orig Mon Aug 21 10:59:52 2000
-+++ Makefile Tue Jun 10 10:29:53 2003
++++ Makefile Sun Aug 17 02:35:19 2003
@@ -44,7 +44,7 @@
#REAL_DAEMON_DIR=/usr/etc
#
@@ -11,23 +11,60 @@
#
# BSD 4.4
#REAL_DAEMON_DIR=/usr/libexec
-@@ -144,7 +144,7 @@
+@@ -90,7 +90,7 @@
+
+ # This is good for many BSD+SYSV hybrids with NIS (formerly YP).
+ generic aix osf alpha dynix:
+- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
++ @$(MAKE) REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
+ LIBS= RANLIB=ranlib ARFLAGS=rv AUX_OBJ=setenv.o \
+ NETGROUP=-DNETGROUP TLI= IPV6="$(IPV6)" all
+
+@@ -132,7 +132,7 @@
+
+ # Freebsd and linux by default have no NIS.
+ 386bsd netbsd bsdos:
+- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
++ @$(MAKE) REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
+ LIBS= RANLIB=ranlib ARFLAGS=rv AUX_OBJ= NETGROUP= TLI= \
+ EXTRA_CFLAGS=-DSYS_ERRLIST_DEFINED VSYSLOG= all
+
+@@ -142,9 +142,9 @@
+ EXTRA_CFLAGS=-DSYS_ERRLIST_DEFINED VSYSLOG= all
+
linux:
- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
+- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
++ @$(MAKE) REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
LIBS= RANLIB=ranlib ARFLAGS=rv AUX_OBJ=setenv.o \
- NETGROUP= TLI= EXTRA_CFLAGS="-DBROKEN_SO_LINGER" all
+ NETGROUP= TLI= EXTRA_CFLAGS="-DBROKEN_SO_LINGER -DSYS_ERRLIST_DEFINED" all
# This is good for many SYSV+BSD hybrids with NIS, probably also for HP-UX 7.x.
hpux hpux8 hpux9 hpux10:
-@@ -185,6 +185,7 @@
+@@ -173,19 +173,20 @@
+
+ # IRIX 4.0.x has a special ar(1) flag.
+ irix4:
+- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
++ @$(MAKE) REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
+ LIBS="-lc -lsun" RANLIB=echo ARFLAGS=rvs AUX_OBJ=setenv.o \
+ NETGROUP=-DNETGROUP TLI= all
+ # IRIX 5.2 is SYSV4 with several broken things (such as -lsocket -lnsl).
+ irix5:
+- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
++ @$(MAKE) REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
+ LIBS=-lsun RANLIB=echo ARFLAGS=rv VSYSLOG= \
+ NETGROUP=-DNETGROUP AUX_OBJ=setenv.o TLI= all
+
# IRIX 6.2 (tucker@math.unc.edu). Must find a better value than 200000.
irix6:
+- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
+irix6.5:
- @make REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
++ @$(MAKE) REAL_DAEMON_DIR=$(REAL_DAEMON_DIR) STYLE=$(STYLE) \
LIBS= RANLIB=echo ARFLAGS=rv VSYSLOG= \
NETGROUP=-DNETGROUP EXTRA_CFLAGS="-DBSD=200000" TLI= all
+
@@ -669,7 +670,7 @@
# Protection against weird shells or weird make programs.
>Release-Note:
>Audit-Trail:
>Unformatted: