>Number:         22699
>Category:       pkg
>Synopsis:       wm/openbox fails to build with gcc3.3
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 05 22:30:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        NetBSD 1.6X, GCC 3.3.1
>Organization:
	
>Environment:
	
	
System: NetBSD concretus.ipv6.stack.nl 1.6X NetBSD 1.6X (GENERIC_LAPTOP) #0: Fri Aug 29 04:01:33 EST 2003 mrg@bigkev.thistledown.com.au:/scratch/mrg/obj/i386/home/mrg/src/netbsd/rosrc/sys/arch/i386/compile/GENERIC_LAPTOP i386
Architecture: i386
Machine: i386
>Description:
	Openbox fails to build, probably because of gcc3. It uses assert(),
	without including <assert.h> in a few places.

	Example build error:
if c++ -DHAVE_CONFIG_H -I. -I. -I..    -I/usr/pkg/include -I/usr/X11R6/include -DNDEBUG -I/usr/pkg/include -I/usr/X11R6/include -I/usr/X11R6/include/freetype2    -DLOCALEPATH=\"/usr/pkg/share/openbox/nls\"  -DBUTTONSDIR=\"/usr/pkg/share/openbox/buttons\"  -DDEFAULTMENU=\"/usr/pkg/share/openbox/menu\"  -DDEFAULTSTYLE=\"/usr/pkg/share/openbox/styles/mbdtex\"  -O2 -march=pentium -I/usr/pkg/include -I/usr/X11R6/include  -I/usr/X11R6/include -Wall -W -MT Configuration.o -MD -MP -MF ".deps/Configuration.Tpo"  -c -o Configuration.o `test -f 'Configuration.cc' || echo './'`Configuration.cc;  then mv ".deps/Configuration.Tpo" ".deps/Configuration.Po";  else rm -f ".deps/Configuration.Tpo"; exit 1;  fi
Configuration.cc: In member function `void Configuration::save()':
Configuration.cc:77: error: `assert' undeclared (first use this function)
Configuration.cc:77: error: (Each undeclared identifier is reported only once 
   for each function it appears in.)
Configuration.cc: In member function `void Configuration::create()':
Configuration.cc:104: error: `assert' undeclared (first use this function)
Configuration.cc: In member function `void Configuration::setValue(const 
   std::string&, bool)':

[snip]

>How-To-Repeat:
	try to build wm/openbox
>Fix:
	Include <assert.h> at appropriate places. The following patches
	suffice:

--- work/openbox-2.2.3/src/Configuration.cc.org	2003-09-05 23:22:32.000000000 +0200
+++ work/openbox-2.2.3/src/Configuration.cc	2003-09-05 23:23:41.000000000 +0200
@@ -34,6 +34,7 @@
 #include "Util.hh"
 
 #include <algorithm>
+#include <assert.h>
 
 using std::string;
 
--- work/openbox-2.2.3/util/epist/epist.hh.org	2003-09-06 00:17:12.000000000 +0200
+++ work/openbox-2.2.3/util/epist/epist.hh	2003-09-06 00:17:44.000000000 +0200
@@ -30,6 +30,7 @@
 #include <string>
 #include <map>
 
+#include <assert.h>
 #include "actions.hh"
 #include "window.hh"
 #include "keytree.hh"
>Release-Note:
>Audit-Trail:
>Unformatted:
 	Snapshot from 28.08.2003