>Number:         22826
>Category:       pkg
>Synopsis:       pkgsrc/audio/gsm does not specify libtool --mode
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 17 05:15:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Ron Roskens
>Release:        NetBSD 1.6W
>Organization:
Elfin
>Environment:
	
	
System: NetBSD hysteria.tx.elfin.net 1.6W NetBSD 1.6W (GENERIC) #1: Mon Aug 18 22:11:25 UTC 2003 root@tidell.tx.elfin.net:/d/d1g/NetBSD/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
	

The file patches/patch-ab for pkgsrc/audio/gsm modifies the gsm sources
Makefile to use libtool for compiling and installing. These cases do not
specify which mode libtool should be using, causing libtool-1.5 to emit
a warning about this.

>How-To-Repeat:
# cd pkgsrc/audio/gsm && make
	
>Fix:

Index: distinfo
===================================================================
RCS file: /cvs/NetBSD/pkgsrc/audio/gsm/distinfo,v
retrieving revision 1.2
diff -b -u -r1.2 distinfo
--- distinfo    18 Apr 2001 12:14:30 -0000      1.2
+++ distinfo    17 Sep 2003 04:30:31 -0000
@@ -3,5 +3,5 @@
 SHA1 (gsm-1.0.10.tar.gz) = ee47a81f4137bf3ce933dc610cb2293055ce9c02
 Size (gsm-1.0.10.tar.gz) = 65928 bytes
 SHA1 (patch-aa) = e976c2ceb5e21bc77c51830cbaef9a94c8e0baf2
-SHA1 (patch-ab) = 989ea8de589a43ebf91c8f78f4b2aa722f6c91d3
+SHA1 (patch-ab) = 88bc6a8d77589f0ee95fca9268ae36a8d4a8b50a
 SHA1 (patch-ac) = 9e4e582cfd4f6892531578d9df25a29485e8cf32
Index: patches/patch-ab
===================================================================
RCS file: /cvs/NetBSD/pkgsrc/audio/gsm/patches/patch-ab,v
retrieving revision 1.6
diff -b -u -r1.6 patch-ab
--- patches/patch-ab    26 Jan 2000 22:09:32 -0000      1.6
+++ patches/patch-ab    17 Sep 2003 04:30:26 -0000
@@ -103,7 +103,7 @@
                @-mv `$(BASENAME) $@` $@ > /dev/null 2>&1
  
 +.c.lo:
-+              cd `${DIRNAME} $@` && ${LIBTOOL} ${CC} ${CFLAGS} $?
++              cd `${DIRNAME} $@` && ${LIBTOOL} --mode=compile ${CC} ${CFLAGS} $?
 +
  # Target rules
  
@@ -118,7 +118,7 @@
 -              $(AR) $(ARFLAGS) $(LIBGSM) $(GSM_OBJECTS)
 -              $(RANLIB) $(LIBGSM)
 +              cd $(LIB) && \
-+                      $(LIBTOOL) $(CC) -o `$(BASENAME) $@` \
++                      $(LIBTOOL) --mode=link $(CC) -o `$(BASENAME) $@` \
 +                              $(GSM_OBJECTS:.o=.lo) \
 +                              -rpath $(GSM_INSTALL_LIB) -version-info 1:10
  
@@ -128,7 +128,7 @@
  $(TOAST):     $(BIN) $(TOAST_OBJECTS) $(LIBGSM)
 -              $(LD) $(LFLAGS) -o $(TOAST) $(TOAST_OBJECTS) $(LIBGSM) $(LDLIB)
 +              cd $(BIN) && \
-+                      $(LIBTOOL) $(LD) $(LFLAGS) -o `$(BASENAME) $@` \
++                      $(LIBTOOL) --mode=link $(LD) $(LFLAGS) -o `$(BASENAME) $@` \
 +                              $(TOAST_OBJECTS) $(LIBGSM) $(LDLIB)
  
  $(UNTOAST):   $(BIN) $(TOAST)
@@ -155,7 +155,7 @@
 -              -rm $@
 -              cp $(TOAST) $@
 -              chmod 755 $@
-+              ${LIBTOOL} ${BSD_INSTALL_PROGRAM} $? $(TOAST_INSTALL_BIN)
++              ${LIBTOOL} --mode=install ${BSD_INSTALL_PROGRAM} $? $(TOAST_INSTALL_BIN)
  
  $(TOAST_INSTALL_BIN)/untoast: $(TOAST_INSTALL_BIN)/toast
 -              -rm $@
@@ -209,7 +209,7 @@
 +              ${BSD_INSTALL_DATA} $? $(GSM_INSTALL_INC)
 +
 +$(GSM_INSTALL_LIB)/libgsm.la: $(LIBGSM)
-+              ${LIBTOOL} ${BSD_INSTALL_DATA} $? $(GSM_INSTALL_LIB)
++              ${LIBTOOL} --mode=install ${BSD_INSTALL_DATA} $? $(GSM_INSTALL_LIB)
  
  
  # Distribution
	
>Release-Note:
>Audit-Trail:
>Unformatted: