Subject: pkg/22992: textproc/aspell doesn't really need ncurses
To: None <gnats-bugs@gnats.netbsd.org>
From: None <tv@duh.org>
List: netbsd-bugs
Date: 09/28/2003 11:45:40
>Number:         22992
>Category:       pkg
>Synopsis:       textproc/aspell doesn't really need ncurses
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 28 15:47:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Todd Vierling
>Release:        NetBSD 1.6.1_STABLE
>Organization:
	DUH.ORG:  Pointing out the obvious since 1994.
>Environment:
System: NetBSD server.duh.org 1.6.1_STABLE NetBSD 1.6.1_STABLE (SERVER) #1: Fri Sep 12 11:28:14 EDT 2003 tv@server.duh.org:/export/SRC/duh/netbsd-kernels/SERVER i386
Architecture: i386
Machine: i386
>Description:

halfdelay(N) is the function supposedly needed by aspell to do its work in
curses mode.  This is not actually needed; it can be emulated by the
sequence cbreak(); timeout(N*100).

With attached additional patch, aspell compiles and runs just fine on
NetBSD 1.6.x with system-supplied curses.  Do note that I haven't confirmed
proper poperation on 1.5.x, but there are no additional functions listed in
the former needs-ncurses comment.

>How-To-Repeat:
>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/aspell/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- Makefile	2003/09/28 09:13:59	1.14
+++ Makefile	2003/09/28 15:42:49
@@ -19,9 +19,6 @@
 USE_LIBTOOL=		yes
 LIBTOOL_OVERRIDE=	${WRKSRC}/libtool
 
-# halfdelay()
-INCOMPAT_CURSES=	NetBSD-1.[45]*-* NetBSD-1.6[-_.]* NetBSD-1.6[A-L]-*
-
 CONFIGURE_ARGS+=	--enable-doc-dir=${PREFIX}/share/doc/aspell
 CONFIGURE_ARGS+=	--enable-curses=ncurses
 
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/textproc/aspell/distinfo,v
retrieving revision 1.5
diff -u -r1.5 distinfo
--- distinfo	2003/07/14 17:06:34	1.5
+++ distinfo	2003/09/28 15:42:49
@@ -3,3 +3,4 @@
 SHA1 (aspell-0.50.3.tar.gz) = aea3c1e47c10bf2f189dbff91c3c137170af6a72
 Size (aspell-0.50.3.tar.gz) = 939063 bytes
 SHA1 (patch-aa) = ec9eff280bdb169814e134f541dee7c879a58fdd
+SHA1 (patch-ab) = 4b69a1549e47e857853aea86b42ec5ed3df80040
Index: patches/patch-ab
===================================================================
RCS file: patch-ab
diff -N patch-ab
--- /dev/null	Thu Jul 11 11:18:53 2002
+++ patch-ab	Sun Sep 28 15:42:49 2003
@@ -0,0 +1,14 @@
+$NetBSD$
+
+--- prog/check_funs.cpp.orig	Sun Sep 28 11:37:02 2003
++++ prog/check_funs.cpp
+@@ -205,7 +205,8 @@ void layout_screen() {
+   choice_w = 0;
+   nonl();
+   noecho();
+-  halfdelay(1);
++  cbreak();
++  timeout(100);
+   keypad(stdscr, true);
+   clear();
+   int height, width;
>Release-Note:
>Audit-Trail:
>Unformatted: