>Number:         23303
>Category:       pkg
>Synopsis:       security/dsniff does not build on -current
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 29 15:56:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator:     Paul Dokas
>Release:        NetBSD 1.6ZC
>Organization:
Department of Computer Science, University of Minnesota
>Environment:
System: NetBSD cdward 1.6ZC NetBSD 1.6ZC (CDWARD) #37: Wed Oct  8 20:15:39 CDT 2003  root@cdward:/usr/obj/sys/arch/i386/compile/CDWARD i386
Architecture: i386
Machine: i386
>Description:

security/dsniff does not build:

cc -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/X11R6/lib -Wl,-R/usr/X11R6/lib -o msgsnarf msgsnarf.o buf.o pcaputil.o -lresolv -lrpcsvc  -L. -lmissing -L/usr/pkg/lib -lnids -lpcap -L/usr/pkg/lib -lnet
cc -O2 -I/usr/pkg/include -I/usr/X11R6/include -D_BSD_SOURCE -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DLIBNET_LIL_ENDIAN -DDSNIFF_LIBDIR=\"/usr/pkg/lib/\" -I. -I/usr/pkg/include  -I/usr/pkg/include   -I/usr/X11R6/include  -I./missing -c ./sshmitm.c
cc -O2 -I/usr/pkg/include -I/usr/X11R6/include -D_BSD_SOURCE -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DLIBNET_LIL_ENDIAN -DDSNIFF_LIBDIR=\"/usr/pkg/lib/\" -I. -I/usr/pkg/include  -I/usr/pkg/include   -I/usr/X11R6/include  -I./missing -c ./ssh.c
cc -O2 -I/usr/pkg/include -I/usr/X11R6/include -D_BSD_SOURCE -DLIBNET_BSDISH_OS -DLIBNET_BSD_BYTE_SWAP -DLIBNET_LIL_ENDIAN -DDSNIFF_LIBDIR=\"/usr/pkg/lib/\" -I. -I/usr/pkg/include  -I/usr/pkg/include   -I/usr/X11R6/include  -I./missing -c ./sshcrypto.c
sshcrypto.c:30: error: parse error before "des_key_schedule"
sshcrypto.c:30: warning: no semicolon at end of struct or union
sshcrypto.c:31: warning: data definition has no type or storage class
sshcrypto.c:32: error: parse error before '}' token
sshcrypto.c: In function `des3_init':
sshcrypto.c:153: error: dereferencing pointer to incomplete type
sshcrypto.c:156: error: dereferencing pointer to incomplete type
sshcrypto.c:157: error: dereferencing pointer to incomplete type
sshcrypto.c:160: error: dereferencing pointer to incomplete type
sshcrypto.c:162: error: dereferencing pointer to incomplete type
sshcrypto.c:164: error: dereferencing pointer to incomplete type
sshcrypto.c:165: error: dereferencing pointer to incomplete type
sshcrypto.c:166: error: dereferencing pointer to incomplete type
sshcrypto.c: In function `des3_encrypt':
sshcrypto.c:176: error: dereferencing pointer to incomplete type
sshcrypto.c:176: error: dereferencing pointer to incomplete type
sshcrypto.c:178: error: dereferencing pointer to incomplete type
sshcrypto.c:178: error: dereferencing pointer to incomplete type
sshcrypto.c:179: error: dereferencing pointer to incomplete type
sshcrypto.c:179: error: dereferencing pointer to incomplete type
sshcrypto.c:180: error: dereferencing pointer to incomplete type
sshcrypto.c:180: error: dereferencing pointer to incomplete type
sshcrypto.c: In function `des3_decrypt':
sshcrypto.c:189: error: dereferencing pointer to incomplete type
sshcrypto.c:189: error: dereferencing pointer to incomplete type
sshcrypto.c:191: error: dereferencing pointer to incomplete type
sshcrypto.c:191: error: dereferencing pointer to incomplete type
sshcrypto.c:192: error: dereferencing pointer to incomplete type
sshcrypto.c:192: error: dereferencing pointer to incomplete type
sshcrypto.c:193: error: dereferencing pointer to incomplete type
sshcrypto.c:193: error: dereferencing pointer to incomplete type
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/dsniff/work/dsniff-2.3
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/dsniff
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/security/dsniff

>How-To-Repeat:

attempt to build security/dsniff

>Fix:


I had to apply the following diffs:


*** Makefile.in.orig    Wed Oct 29 09:53:22 2003
--- Makefile.in Wed Oct 29 09:54:01 2003
***************
*** 32,38 ****
  DBLIB = @DBLIB@
  
  SSLINC        = @SSLINC@
! SSLLIB        = @SSLLIB@
  
  X11INC        = @X_CFLAGS@
  X11LIB        = @X_LIBS@ @X_PRE_LIBS@ -lXmu -lX11 @X_EXTRA_LIBS@
--- 32,38 ----
  DBLIB = @DBLIB@
  
  SSLINC        = @SSLINC@
! SSLLIB        = @SSLLIB@ -ldes
  
  X11INC        = @X_CFLAGS@
  X11LIB        = @X_LIBS@ @X_PRE_LIBS@ -lXmu -lX11 @X_EXTRA_LIBS@


*** sshcrypto.c.orig    Wed Oct 29 09:40:18 2003
--- sshcrypto.c Wed Oct 29 09:43:42 2003
***************
*** 14,19 ****
--- 14,20 ----
  
  #include <sys/types.h>
  #include <openssl/ssl.h>
+ #include <des.h>
  
  #include <err.h>
  #include <stdio.h>
>Release-Note:
>Audit-Trail:
>Unformatted: