Subject: kern/23354: [PATCH] uninitialized variables in if_pppoe.c and fwiso.c
To: None <gnats-bugs@gnats.netbsd.org>
From: None <naoki@fukaumi.org>
List: netbsd-bugs
Date: 11/03/2003 14:19:10
>Number: 23354
>Category: kern
>Synopsis: [PATCH] uninitialized variables in if_pppoe.c and fwiso.c
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Nov 03 05:20:00 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator: FUKAUMI Naoki
>Release: NetBSD 1.6ZE
>Organization:
FUKAUMI Naoki
>Environment:
System: NetBSD tr1.naobsd.org 1.6ZE NetBSD 1.6ZE (TR1) #0: Mon Oct 27 08:34:42 JST 2003 root@tr1.naobsd.org:/usr/obj/i386/sys/arch/i386/compile/TR1 i386
Architecture: i386
Machine: i386
>Description:
See Synopsis and Fix.
>How-To-Repeat:
build kernel with
pseudo-device fwiso 4
options PPPOE_SERVER
>Fix:
Index: sys/net/if_pppoe.c
===================================================================
RCS file: /home/fun/cvsroot/NetBSD/src/sys/net/if_pppoe.c,v
retrieving revision 1.50
diff -u -r1.50 if_pppoe.c
--- sys/net/if_pppoe.c 30 Oct 2003 01:43:08 -0000 1.50
+++ sys/net/if_pppoe.c 3 Nov 2003 05:10:09 -0000
@@ -1317,7 +1317,7 @@
{
struct mbuf *m0;
u_int8_t *p;
- size_t len, l1;
+ size_t len, l1 = 0; /* XXX: gcc */
if (sc->sc_state != PPPOE_STATE_PADO_SENT)
return EIO;
Index: sys/dev/ieee1394/fwiso.c
===================================================================
RCS file: /home/fun/cvsroot/NetBSD/src/sys/dev/ieee1394/fwiso.c,v
retrieving revision 1.3
diff -u -r1.3 fwiso.c
--- sys/dev/ieee1394/fwiso.c 14 Jul 2003 15:47:13 -0000 1.3
+++ sys/dev/ieee1394/fwiso.c 3 Nov 2003 05:12:45 -0000
@@ -839,7 +839,7 @@
static int
fwiso_set_handler(struct fwiso_data *fd)
{
- int bufsize;
+ int bufsize = 0; /* XXX: gcc */
int s;
struct ieee1394_softc *isc = fd->fd_dev;
int flags = 0;
>Release-Note:
>Audit-Trail:
>Unformatted: