Subject: pkg/23570: devel/atk should depend on gettext-lib instead of libiconv
To: None <gnats-bugs@gnats.netbsd.org>
From: Min Sik Kim <minskim@bawi.org>
List: netbsd-bugs
Date: 11/25/2003 14:37:18
>Number: 23570
>Category: pkg
>Synopsis: devel/atk should depend on gettext-lib instead of libiconv
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: pkg-manager
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Nov 25 20:38:01 UTC 2003
>Closed-Date:
>Last-Modified:
>Originator: Min Sik Kim
>Release: NetBSD 1.6ZF
>Organization:
>Environment:
System: NetBSD mike.infnis.com 1.6ZF NetBSD 1.6ZF (MIKE) #8: Sat Nov 22 02:01:55 CST 2003 root@mike.infnis.com:/usr/obj/sys/arch/i386/compile/MIKE i386
Architecture: i386
Machine: i386
>Description:
devel/atk includes converters/libiconv/buildlink2.mk in its Makefile.
Because atk itself doesn't use iconv, this should be removed.
Instead, including devel/gettext-lib would take care of libiconv
dependency.
>How-To-Repeat:
>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/atk/Makefile,v
retrieving revision 1.20
diff -u -r1.20 Makefile
--- Makefile 2003/08/27 09:17:25 1.20
+++ Makefile 2003/11/25 20:21:37
@@ -26,8 +26,8 @@
# glib-mkenums overflows a 2048kb stack on atkobject.h
UNLIMIT_RESOURCES= stacksize
+.include "../../devel/gettext-lib/buildlink2.mk"
.include "../../devel/glib2/buildlink2.mk"
.include "../../devel/pkgconfig/buildlink2.mk"
-.include "../../converters/libiconv/buildlink2.mk"
.include "../../mk/bsd.pkg.mk"
Index: buildlink2.mk
===================================================================
RCS file: /cvsroot/pkgsrc/devel/atk/buildlink2.mk,v
retrieving revision 1.8
diff -u -r1.8 buildlink2.mk
--- buildlink2.mk 2003/11/25 12:21:27 1.8
+++ buildlink2.mk 2003/11/25 20:21:37
@@ -18,8 +18,8 @@
BUILDLINK_FILES.atk+= include/atk-1.0/*
BUILDLINK_FILES.atk+= lib/libatk-1.0.*
+.include "../../devel/gettext-lib/buildlink2.mk"
.include "../../devel/glib2/buildlink2.mk"
-.include "../../converters/libiconv/buildlink2.mk"
BUILDLINK_TARGETS+= atk-buildlink
>Release-Note:
>Audit-Trail:
>Unformatted: