Subject: Re: pkg/24056: gst-plugins (current) does not build
To: None <netbsd-install@home.nl, netbsd-bugs@netbsd.org>
From: Quentin Garnier <quentin@eve-team.com>
List: netbsd-bugs
Date: 01/12/2004 10:19:22
This is a multi-part message in MIME format.

--Multipart=_Mon__12_Jan_2004_10_19_22_+0100_4YIVpFJ./8Jx8r_y
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 11 Jan 2004 23:39:33 +0000 (UTC)
netbsd-install@home.nl wrote:

> 
> >Number:         24056
> >Category:       pkg
> >Synopsis:       gst-plugins (current) does not build
[...]
> ./.libs/liblavplay.so: undefined reference to `pthread_setschedparam'
> gmake[2]: *** [lavplay] Error 1
> gmake[2]: Leaving directory
> `/usr/pkgsrc/graphics/mjpegtools/work/mjpegtools-1.6.1.90/lavtools'
> gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory
> `/usr/pkgsrc/graphics/mjpegtools/work/mjpegtools-1.6.1.90' gmake: ***
> [all] Error 2*** Error code 2
> 
> Stop.
> make: stopped in /usr/pkgsrc/graphics/mjpegtools

This is not a gst-plugins issue, but rather a mjpegtools issue.

1. pthread_setschedparam was added in 1.6ZG.  Updating your system will
   fix the issue you see.  We can't possibly support every single
   existing version of -current.

2. Even after that, mjpegtools is still broken on -current because of
   bad libtool/iconv interaction.  Could you please try the attached
   patch?  Without your patch to gst-plugins of course.

Providing a patch along with the PR is appreciated, but I'm sure you
knew your patch didn't belong to a section named 'Fix' :)

Quentin Garnier.

--Multipart=_Mon__12_Jan_2004_10_19_22_+0100_4YIVpFJ./8Jx8r_y
Content-Type: text/plain;
 name="mjpegtools.diff"
Content-Disposition: attachment;
 filename="mjpegtools.diff"
Content-Transfer-Encoding: 7bit

Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/graphics/mjpegtools/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile	2004/01/03 18:49:43	1.12
+++ Makefile	2004/01/12 09:12:35
@@ -16,6 +16,7 @@
 USE_GMAKE=		yes
 
 USE_LIBTOOL=		yes
+LIBTOOL_OVERRIDE=	${WRKSRC}/libtool
 SHLIBTOOL_OVERRIDE=	${WRKSRC}/ltmain.sh
 PKGCONFIG_OVERRIDE=	mjpegtools.pc.in
 
Index: PLIST
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/graphics/mjpegtools/PLIST,v
retrieving revision 1.3
diff -u -r1.3 PLIST
--- PLIST	2003/12/16 07:26:49	1.3
+++ PLIST	2004/01/12 09:12:35
@@ -52,20 +52,20 @@
 info/mjpeg-howto.info-2
 info/mjpeg-howto.info-3
 lib/liblavfile-1.6.so
+lib/liblavfile-1.6.so.1
 lib/liblavfile-1.6.so.1.90
-lib/liblavfile-1.6.so.1.90.1.90
 lib/liblavfile.a
 lib/liblavfile.la
 lib/liblavfile.so
 lib/liblavjpeg-1.6.so
+lib/liblavjpeg-1.6.so.1
 lib/liblavjpeg-1.6.so.1.90
-lib/liblavjpeg-1.6.so.1.90.1.90
 lib/liblavjpeg.a
 lib/liblavjpeg.la
 lib/liblavjpeg.so
 lib/liblavplay-1.6.so
+lib/liblavplay-1.6.so.1
 lib/liblavplay-1.6.so.1.90
-lib/liblavplay-1.6.so.1.90.1.90
 lib/liblavplay.a
 lib/liblavplay.la
 lib/liblavplay.so
Index: distinfo
===================================================================
RCS file: /pub/NetBSD-CVS/pkgsrc/graphics/mjpegtools/distinfo,v
retrieving revision 1.5
diff -u -r1.5 distinfo
--- distinfo	2003/12/16 07:26:49	1.5
+++ distinfo	2004/01/12 09:12:35
@@ -3,3 +3,5 @@
 SHA1 (mjpegtools-1.6.1.90.tar.gz) = c66ed5ba3cb5b8835facaeeb80b05bb9f5014206
 Size (mjpegtools-1.6.1.90.tar.gz) = 1168921 bytes
 SHA1 (patch-ab) = 5562496d75bc470ffe6030e9fea02c94a22855e7
+SHA1 (patch-ag) = 88437c6be17bc6140e2fb28a0a37ae69edf4fe89
+SHA1 (patch-ah) = eda857e29601b904873502dd36af343eeff9c06d
--- /dev/null	2004-01-12 10:08:15.000000000 +0100
+++ patches/patch-ag	2004-01-12 09:58:08.000000000 +0100
@@ -0,0 +1,29 @@
+$NetBSD$
+
+--- configure.in.orig	2003-08-23 16:21:31.000000000 +0200
++++ configure.in
+@@ -3,8 +3,9 @@ AC_INIT(lavtools/lav_io.c)
+ 
+ MJPEG_MAJOR_VERSION=1
+ MJPEG_MINOR_VERSION=6
+-MJPEG_MICRO_VERSION=1.90
+-MJPEG_VERSION=$MJPEG_MAJOR_VERSION.$MJPEG_MINOR_VERSION.$MJPEG_MICRO_VERSION
++MJPEG_MICRO_MAJOR_VERSION=1
++MJPEG_MICRO_MINOR_VERSION=90
++MJPEG_VERSION=$MJPEG_MAJOR_VERSION.$MJPEG_MINOR_VERSION.$MJPEG_MICRO_MAJOR_VERSION.$MJPEG_MICRO_MINOR_VERSION
+ 
+ AC_CONFIG_HEADER(config.h)
+ AC_CANONICAL_HOST
+@@ -15,9 +16,9 @@ AM_OUTPUT_DEPENDENCY_COMMANDS
+ 
+ # libtool versioning
+ LT_RELEASE=$MJPEG_MAJOR_VERSION.$MJPEG_MINOR_VERSION
+-LT_CURRENT=$MJPEG_MICRO_VERSION
+-LT_REVISION=$MJPEG_MICRO_VERSION
+-LT_AGE=$MJPEG_MICRO_VERSION
++LT_CURRENT=$MJPEG_MICRO_MAJOR_VERSION
++LT_REVISION=$MJPEG_MICRO_MINOR_VERSION
++LT_AGE=$MJPEG_MICRO_MAJOR_VERSION
+ AC_SUBST(LT_RELEASE)
+ AC_SUBST(LT_CURRENT)
+ AC_SUBST(LT_REVISION)
--- /dev/null	2004-01-12 10:08:15.000000000 +0100
+++ patches/patch-ah	2004-01-12 09:58:08.000000000 +0100
@@ -0,0 +1,29 @@
+$NetBSD$
+
+--- configure.orig	2003-08-23 16:21:58.000000000 +0200
++++ configure
+@@ -1493,8 +1493,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
+ 
+ MJPEG_MAJOR_VERSION=1
+ MJPEG_MINOR_VERSION=6
+-MJPEG_MICRO_VERSION=1.90
+-MJPEG_VERSION=$MJPEG_MAJOR_VERSION.$MJPEG_MINOR_VERSION.$MJPEG_MICRO_VERSION
++MJPEG_MICRO_MAJOR_VERSION=1
++MJPEG_MICRO_MINOR_VERSION=90
++MJPEG_VERSION=$MJPEG_MAJOR_VERSION.$MJPEG_MINOR_VERSION.$MJPEG_MICRO_MAJOR_VERSION.$MJPEG_MICRO_MINOR_VERSION
+ 
+           ac_config_headers="$ac_config_headers config.h"
+ 
+@@ -1990,9 +1991,9 @@ fi
+ 
+ # libtool versioning
+ LT_RELEASE=$MJPEG_MAJOR_VERSION.$MJPEG_MINOR_VERSION
+-LT_CURRENT=$MJPEG_MICRO_VERSION
+-LT_REVISION=$MJPEG_MICRO_VERSION
+-LT_AGE=$MJPEG_MICRO_VERSION
++LT_CURRENT=$MJPEG_MICRO_MAJOR_VERSION
++LT_REVISION=$MJPEG_MICRO_MINOR_VERSION
++LT_AGE=$MJPEG_MICRO_MAJOR_VERSION
+ 
+ 
+ 

--Multipart=_Mon__12_Jan_2004_10_19_22_+0100_4YIVpFJ./8Jx8r_y--