Subject: kern/24193: Can no longer use kernel options ATPPC_DEBUG or ATPPC_VERBOSE
To: None <gnats-bugs@gnats.NetBSD.org>
From: Paul Shupak <paul@svcs.plectere.com>
List: netbsd-bugs
Date: 01/22/2004 06:07:00
>Number: 24193
>Category: kern
>Synopsis: Can no longer use kernel options ATPPC_DEBUG or ATPPC_VERBOSE
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Jan 22 14:08:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator: Paul Shupak
>Release: NetBSD 1.6ZH
>Organization:
>Environment:
System: NetBSD svcs 1.6ZH NetBSD 1.6ZH (SVCS) #5: Mon Jan 12 11:31:51 PST 2004 root@svcs:/sys/arch/i386/compile/SVCS i386
Architecture: i386
Machine: i386
>Description:
Beginning in revision 1.4 of sys/dev/ic/atppc.c a declaration
was removed which is used IFF ATPPC_DEBUG if defined. This
must have given someone an unused variable error: It should be
ifdef'ed - it is used for both DEBUG and VERBOSE messages in
the function.
>How-To-Repeat:
Try to build a kernel with "options ATPPC_DEBUG"
>Fix:
Index: atppc.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/atppc.c,v
retrieving revision 1.4
diff -c -r1.4 atppc.c
*** atppc.c 2004/01/22 01:21:41 1.4
--- atppc.c 2004/01/22 14:00:03
***************
*** 152,157 ****
--- 152,160 ----
#ifdef ATPPC_VERBOSE
char buf[64];
#endif
+ #ifdef ATPPC_DEBUG
+ struct device * dev = (struct device *) lsc;
+ #endif
printf("\n");
***************
>Release-Note:
>Audit-Trail:
>Unformatted: