Subject: pkg/24215: PKG_INSTALLATION_TYPES is ignored in Mesa, glu, and glut
To: None <gnats-bugs@gnats.NetBSD.org>
From: Min Sik Kim <minskim@bawi.org>
List: netbsd-bugs
Date: 01/24/2004 11:45:46
>Number:         24215
>Category:       pkg
>Synopsis:       PKG_INSTALLATION_TYPES is ignored in Mesa, glu, and glut
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 24 17:46:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Min Sik Kim
>Release:        NetBSD 1.6ZH
>Organization:
>Environment:
>Description:
PKG_INSTALLATION_TYPES is set to "overwrite pkgviews" in Mesa, glu,
and glut, but they are built only as overwrite packages because
graphics/Mesa/Makefile.common, which is included earlier than setting
PKG_INSTALLATION_TYPES, includes bsd.prefs.mk.

>How-To-Repeat:

In graphics/MesaLib, graphics/glu, and graphics/glut:

% make PKG_INSTALLATION_PREFS="pkgviews overwrite" show-var VARNAME=PKG_INSTALLATION_TYPE
overwrite


>Fix:

Do not include bsd.prefs.mk in Mesa/Makefile.common (the following
patch).  Makefile of each package includes it anyway.

Alternatively, declare PKG_INSTALLATION_TYPES earlier.

Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/Mesa/Makefile.common,v
retrieving revision 1.23
diff -u -r1.23 Makefile.common
--- Makefile.common	2004/01/23 19:37:18	1.23
+++ Makefile.common	2004/01/24 17:41:13
@@ -27,5 +27,3 @@
 	for lib in ${INSTLIBS}; do	\
 	    ${LIBTOOL} --mode=install ${INSTALL_DATA} $${lib} ${PREFIX}/lib ; \
 	done;
-
-.include "../../mk/bsd.prefs.mk"
>Release-Note:
>Audit-Trail:
>Unformatted:
 Environment:
 System: NetBSD sulley.infnis.com 1.6ZH NetBSD 1.6ZH (SULLEY) #3: Fri Jan 16 16:57:45 CST 2004 root@sulley.infnis.com:/usr/obj/sys/arch/i386/compile/SULLEY i386
 Architecture: i386
 Machine: i386