>Number:         24779
>Category:       toolchain
>Synopsis:       TARGET_ENDIANNESS' value change from "1234" to "little", ...
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 14 14:06:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Stoned Elipot
>Release:        NetBSD 1.6ZK
>Organization:
>Environment:
System: NetBSD runabout 1.6ZK NetBSD 1.6ZK (RUNABOUT) #15: Sun Mar 14 11:25:29 CET 2004 seb@runabout:/home/seb/src/RUNABOUT/kernel/compile i386
Architecture: i386
Machine: i386
>Description:
src/share/mk/bsd.endian.mk revision 1.6 changed the possible values of
TARGET_ENDIANNESS has from "1234", "4321", ... to "little", "big" and "unknown".

Various test of TARGET_ENDIANNESS would need to be changed accordingly.
Or the change introduced would need to be fixed ie keeping the old
values of "1234", ...

Note that pkgsrc/mk/endian.mk which predates bsd.endian.mk by a month or so
does set MACHINE_ENDIAN to "little", "big", ... ;)
>How-To-Repeat:
cd /usr/src/etc
make -V PWD_MKDB_ENDIAN
>Fix:
Here are diffs that fix various test of TARGET_ENDIANNESS by
considering the new set of its values.


Index: etc/Makefile
===================================================================
RCS file: /cvsroot/src/etc/Makefile,v
retrieving revision 1.284
diff -u -u -r1.284 Makefile
--- etc/Makefile	8 Mar 2004 05:46:44 -0000	1.284
+++ etc/Makefile	14 Mar 2004 13:49:02 -0000
@@ -127,9 +127,9 @@
 
 SSH=	ssh_known_hosts
 
-.if ${TARGET_ENDIANNESS} == "1234"
+.if ${TARGET_ENDIANNESS} == "little"
 PWD_MKDB_ENDIAN=	-L
-.elif ${TARGET_ENDIANNESS} == "4321"
+.elif ${TARGET_ENDIANNESS} == "big"
 PWD_MKDB_ENDIAN=	-B
 .else
 PWD_MKDB_ENDIAN=
Index: share/termcap/Makefile
===================================================================
RCS file: /cvsroot/src/share/termcap/Makefile,v
retrieving revision 1.29
diff -u -u -r1.29 Makefile
--- share/termcap/Makefile	21 Oct 2003 10:01:20 -0000	1.29
+++ share/termcap/Makefile	14 Mar 2004 13:49:02 -0000
@@ -10,9 +10,9 @@
 FILESDIR=${BINDIR}/misc
 
 .include <bsd.endian.mk>
-.if ${TARGET_ENDIANNESS} == "1234"
+.if ${TARGET_ENDIANNESS} == "little"
 CAP_MKDB_ENDIAN=	-l
-.elif ${TARGET_ENDIANNESS} == "4321"
+.elif ${TARGET_ENDIANNESS} == "big"
 CAP_MKDB_ENDIAN=	-b
 .else
 CAP_MKDB_ENDIAN=
Index: usr.bin/vgrind/Makefile
===================================================================
RCS file: /cvsroot/src/usr.bin/vgrind/Makefile,v
retrieving revision 1.19
diff -u -u -r1.19 Makefile
--- usr.bin/vgrind/Makefile	21 Oct 2003 10:01:22 -0000	1.19
+++ usr.bin/vgrind/Makefile	14 Mar 2004 13:49:02 -0000
@@ -24,9 +24,9 @@
 realall: vfontedpr vgrindefs.src.db
 
 .include <bsd.endian.mk>
-.if ${TARGET_ENDIANNESS} == "1234"
+.if ${TARGET_ENDIANNESS} == "little"
 CAP_MKDB_ENDIAN=	-l
-.elif ${TARGET_ENDIANNESS} == "4321"
+.elif ${TARGET_ENDIANNESS} == "big"
 CAP_MKDB_ENDIAN=	-b
 .else
 CAP_MKDB_ENDIAN=
Index: x11/Xserver/GL/dri/mga_dri/Makefile
===================================================================
RCS file: /cvsroot/src/x11/Xserver/GL/dri/mga_dri/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- x11/Xserver/GL/dri/mga_dri/Makefile	6 Mar 2004 10:30:26 -0000	1.1
+++ x11/Xserver/GL/dri/mga_dri/Makefile	14 Mar 2004 13:49:03 -0000
@@ -65,9 +65,9 @@
 
 .include <bsd.endian.mk>
 
-.if ${TARGET_ENDIANNESS} == "1234"
+.if ${TARGET_ENDIANNESS} == "little"
 X_BYTE_ORDER=X_LITTLE_ENDIAN
-.elif ${TARGET_ENDIANNESS} == "4321"
+.elif ${TARGET_ENDIANNESS} == "big"
 X_BYTE_ORDER=X_BIG_ENDIAN
 .else
 X_BYTE_ORDER=0
Index: x11/Xserver/GL/dri/radeon_dri/Makefile
===================================================================
RCS file: /cvsroot/src/x11/Xserver/GL/dri/radeon_dri/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- x11/Xserver/GL/dri/radeon_dri/Makefile	6 Mar 2004 10:30:26 -0000	1.1
+++ x11/Xserver/GL/dri/radeon_dri/Makefile	14 Mar 2004 13:49:03 -0000
@@ -65,9 +65,9 @@
 
 .include <bsd.endian.mk>
 
-.if ${TARGET_ENDIANNESS} == "1234"
+.if ${TARGET_ENDIANNESS} == "little"
 X_BYTE_ORDER=X_LITTLE_ENDIAN
-.elif ${TARGET_ENDIANNESS} == "4321"
+.elif ${TARGET_ENDIANNESS} == "big"
 X_BYTE_ORDER=X_BIG_ENDIAN
 .else
 X_BYTE_ORDER=0
Index: x11/Xserver/Makefile.serverlib
===================================================================
RCS file: /cvsroot/src/x11/Xserver/Makefile.serverlib,v
retrieving revision 1.5
diff -u -u -r1.5 Makefile.serverlib
--- x11/Xserver/Makefile.serverlib	7 Feb 2004 06:52:04 -0000	1.5
+++ x11/Xserver/Makefile.serverlib	14 Mar 2004 13:49:03 -0000
@@ -11,9 +11,9 @@
 libinstall::
 .endif
 
-.if ${TARGET_ENDIANNESS} == "1234"
+.if ${TARGET_ENDIANNESS} == "little"
 X_BYTE_ORDER=X_LITTLE_ENDIAN
-.elif ${TARGET_ENDIANNESS} == "4321"
+.elif ${TARGET_ENDIANNESS} == "big"
 X_BYTE_ORDER=X_BIG_ENDIAN
 .else
 X_BYTE_ORDER=0
>Release-Note:
>Audit-Trail:
>Unformatted: