Subject: kern/26776: raidframe will not build with with 'options RAID_DIAGNOSTIC'
To: None <gnats-bugs@gnats.NetBSD.org>
From: None <palle@lyckegaard.dk>
List: netbsd-bugs
Date: 08/27/2004 08:58:20
>Number:         26776
>Category:       kern
>Synopsis:       raidframe will not build with with 'options RAID_DIAGNOSTIC'
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 27 08:59:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Palle Lyckegaard
>Release:        netbsd-2-0 BETA
>Organization:
>Environment:
odin# uname -a
NetBSD odin.lyckegaard.dk 2.0_BETA NetBSD 2.0_BETA (ODIN) #0: Thu Aug 19 14:28:09 CEST 2004  palle@odin.lyckegaard.dk:/mnt/cvs/netbsd-2-0/src/sys/arch/i386/compile/obj/ODIN i386

>Description:
The kernel will not compile with 'options RAID_DIAGNISTIC'.

The following three files need minor ajustments (all related to RF_ASSERT()):

sys/dev/raidframe/rf_dagdegrd.c
sys/dev/raidframe/rf_dagffwr.c
sys/dev/raidframe/rf_raid0.c


>How-To-Repeat:
Add the following line to the GENERIC configuration:

options RAID_DIAGNOSTIC
>Fix:
The following are diffs making the kernel build with RAID_DIAGNISTIC again:

odin# cvs diff sys/dev/raidframe/rf_dagdegrd.c
Index: sys/dev/raidframe/rf_dagdegrd.c
===================================================================
RCS file: /cvsroot/src/sys/dev/raidframe/rf_dagdegrd.c,v
retrieving revision 1.21
diff -r1.21 rf_dagdegrd.c
528c528
<               RF_ASSERT(rrdNode->numSuccedents == 1);
---
>               RF_ASSERT(rrdNodes->numSuccedents == 1);


odin# cvs diff sys/dev/raidframe/rf_dagffwr.c
Index: sys/dev/raidframe/rf_dagffwr.c
===================================================================
RCS file: /cvsroot/src/sys/dev/raidframe/rf_dagffwr.c,v
retrieving revision 1.26.2.1
diff -r1.26.2.1 rf_dagffwr.c
412c412
<                       RF_ASSERT(tmpNode.numAntecedents == 1);
---
>                       RF_ASSERT(tmpNode->numAntecedents == 1);
418c418
<                       RF_ASSERT(tmpNode.numSuccedents == 1);
---
>                       RF_ASSERT(tmpNode->numSuccedents == 1);
1113c1113
<               RF_ASSERT(tmpwriteDataNodes->numAntecedents == 1);
---
>               RF_ASSERT(tmpwriteDataNode->numAntecedents == 1);


odin# cvs diff sys/dev/raidframe/rf_raid0.c
Index: sys/dev/raidframe/rf_raid0.c
===================================================================
RCS file: /cvsroot/src/sys/dev/raidframe/rf_raid0.c,v
retrieving revision 1.10
diff -r1.10 rf_raid0.c
74c74
<       RF_ASSERT(raidPtr->numRow == 1);
---
>       RF_ASSERT(raidPtr->numCol == 1);




>Release-Note:
>Audit-Trail:
>Unformatted: