>Number:         27065
>Category:       xsrc
>Synopsis:       some recent changes to twm were never even compiled, let alone tested
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    xsrc-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 28 18:31:00 UTC 2004
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        NetBSD 1.6.2_STABLE
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:
System: NetBSD building 1.6.2_STABLE NetBSD 1.6.2_STABLE (BUILDING.MP) #0: Tue Jun 15 11:55:00 EDT 2004 woods@building:/build/woods/building/NetBSD-1.6.x-alpha-alpha-obj/proven/work/woods/m-NetBSD-1.6/sys/arch/alpha/compile/BUILDING.MP alpha
Architecture: alpha
Machine: alpha
>Description:

	It seems some recent changes to xsrc/programs/twm were never
	even compiled before being committed, let alone tested.  I don't
	think that there's an asnprintf() on -current, but even if there
	is, or were to be, the changed calls could not match its prototype.

>How-To-Repeat:

	Build X11 on a netbsd-1-6 machine that still uses xsrc/xc, such
	as alpha, get no x11 sets and wonder why not, and then observe
	the following in the build log:

making all in programs/twm...
rm -f twm
gcc -o twm -pipe -O2 -mno-soft-float -mcpu=21164a -g -ansi -Dasm=__asm  -static   -L../../exports/lib gram.o lex.o de
ftwmrc.o add_window.o gc.o list.o twm.o                 parse.o menus.o events.o resize.o util.o version.o iconmgr.o 
                cursor.o icons.o session.o -lXmu -lXt -lSM -lICE -lXext -lX11 -lXt -lSM -lICE  -lXext -lX11 -L/usr/X1
1R6/lib     -Wl,-rpath,/usr/X11R6/lib -Wl,-rpath-link,../../exports/lib -Wl,-rpath,/lib
util.o: In function `ExpandFilename':
/build/woods/building/NetBSD-1.6.x-alpha-alpha-obj/xsrc/xc/programs/twm/util.c:287: undefined reference to `asnprintf
'
/build/woods/building/NetBSD-1.6.x-alpha-alpha-obj/xsrc/xc/programs/twm/util.c:287: undefined reference to `asnprintf
'
util.o: In function `FindBitmap':
/build/woods/building/NetBSD-1.6.x-alpha-alpha-obj/xsrc/xc/programs/twm/util.c:391: undefined reference to `asnprintf
'
/build/woods/building/NetBSD-1.6.x-alpha-alpha-obj/xsrc/xc/programs/twm/util.c:391: undefined reference to `asnprintf
'
*** Error code 1

Stop.
make: stopped in /build/woods/building/NetBSD-1.6.x-alpha-alpha-obj/xsrc/xc/programs/twm

>Fix:

Index: xc/programs/twm/util.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/xsrc/xc/programs/twm/util.c,v
retrieving revision 1.2
diff -u -r1.2 util.c
--- xc/programs/twm/util.c	25 Jun 2004 13:28:29 -0000	1.2
+++ xc/programs/twm/util.c	28 Sep 2004 17:56:24 -0000
@@ -284,7 +284,7 @@
 
     if (name[0] != '~') return name;
 
-    asnprintf(&newname, "%s/%s", Home, &name[1]);
+    asprintf(&newname, "%s/%s", Home, &name[1]);
     if (!newname) {
 	fprintf (stderr, 
 		 "%s:  unable to allocate %d bytes to expand filename %s/%s\n",
@@ -388,7 +388,7 @@
 	/*
 	 * Attempt to find icon in old IconDirectory (now obsolete)
 	 */
-	asnprintf(&bigname, "%s/%s", Scr->IconDirectory, name);
+	asprintf(&bigname, "%s/%s", Scr->IconDirectory, name);
 	if (!bigname) {
 	    fprintf (stderr,
 		     "%s:  unable to allocate memory for \"%s/%s\"\n",
>Release-Note:
>Audit-Trail:
>Unformatted: