Subject: kern/28837: incorrect #undef in sys/dev/wscons/wsdisplay_compat_usl.c
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <stefan@binarchy.net>
List: netbsd-bugs
Date: 01/02/2005 15:33:00
>Number:         28837
>Category:       kern
>Synopsis:       In sys/dev/wscons/wsdisplay_compat_usl.c, a macro called ss is being undefined incorrectly.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 02 15:33:00 +0000 2005
>Originator:     stsp@binarchy.net
>Release:        NetBSD 2.0
>Organization:
	
>Environment:
System: NetBSD stud.seeling33.de 2.0 NetBSD 2.0 (STUD) #0: Sun Jan 2 01:34:51 UTC 2005 root@stud.seeling33.de:/usr/src/sys/arch/i386/compile/STUD i386
Architecture: i386
Machine: i386
>Description:
	In /usr/src/sys/dev/wscons/wsdisplay_compat_usl.c, line 313, a macro called 'ss'
        is defined. Line 321 of the file says: '#undef s'
        Since there is no macro called 's' defined anywhere in the file, and ss is
        not used anymore after line 321, I believe line 321 should read '#undef ss'.
>How-To-Repeat:
>Fix:
--- sys/dev/wscons/wsdisplay_compat_usl.c.orig	2005-01-02 14:59:22.000000000 +0100
+++ sys/dev/wscons/wsdisplay_compat_usl.c	2005-01-02 14:59:32.000000000 +0100
@@ -318,7 +318,7 @@
 		for (idx = 0; idx <= maxidx; idx++)
 			if (wsdisplay_screenstate(sc, idx) == EBUSY)
 				ss->v_state |= (1 << (idx + 1));
-#undef s
+#undef ss
 		return (0);
 
 #ifdef WSDISPLAY_COMPAT_PCVT

--99FDD19F.1104679457/stud.seeling33.de--