Subject: xsrc/29003: Re: xsrc/29003: Bug in xterm (fwd)
To: None <xsrc-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Thomas Dickey <dickey@his.com>
List: netbsd-bugs
Date: 01/19/2005 11:18:02
The following reply was made to PR xsrc/29003; it has been noted by GNATS.
From: Thomas Dickey <dickey@his.com>
To: Matthias Scheler <tron@NetBSD.org>
Cc: NetBSD GNATS <gnats-bugs@netbsd.org>
Subject: Re: xsrc/29003: Bug in xterm (fwd)
Date: Wed, 19 Jan 2005 06:17:20 -0500 (EST)
On Wed, 19 Jan 2005, Matthias Scheler wrote:
> On Tue, Jan 18, 2005 at 06:46:19PM -0500, Thomas Dickey wrote:
>> I hadn't seen that one (there were a lot of changes in #171 a couple of
>> years ago, mostly good but a few bugs). A quick check shows 21 places in
>> the state table that can get there, including the default ansi_table.
>> That one looks like an error; the others I'll have to sift through and
>> check for other possible errors). The
>>
>> if (!string_used)
>> break;
>>
>> does guard against most errors.
>>
>> Resetting the state to ground at the beginning does ensure that the check
>> if there's no string_used doesn't prevent the state from resetting
>> (agree).
>
> To be sure I get this right: the fix is worth committing?
yes - the rest of my comment was saying (for my reference as well) that I
should examine that slice more carefully to see if there are other issues.
--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net