Subject: xsrc/29008: Re: xsrc/29008: src/11/Xserver/cfb/Makefile.cfb doesn't use optional STIPPLE_CODE
To: None <xsrc-manager@netbsd.org, gnats-admin@netbsd.org,>
From: List Mail User <track@Plectere.com>
List: netbsd-bugs
Date: 01/19/2005 12:56:01
The following reply was made to PR xsrc/29008; it has been noted by GNATS.
From: List Mail User <track@Plectere.com>
To: gnats-bugs@NetBSD.org
Cc: track@Plectere.com
Subject: Re: xsrc/29008: src/11/Xserver/cfb/Makefile.cfb doesn't use optional STIPPLE_CODE
Date: Wed, 19 Jan 2005 04:55:49 -0800 (PST)
>From bounces-netbsd-bugs-owner-track=Plectere.com@NetBSD.org Wed Jan 19 01:38:05 2005
>X-Original-To: netbsd-bugs@netbsd.org
>Delivered-To: netbsd-bugs@netbsd.org
>From: tsutsui@ceres.dti.ne.jp
>To: xsrc-manager@NetBSD.org, gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
>Reply-To: gnats-bugs@NetBSD.org
>Subject: xsrc/29008: src/11/Xserver/cfb/Makefile.cfb doesn't use optional STIPPLE_CODE
>Cc:
>Date: Wed, 19 Jan 2005 09:37:01 +0000 (UTC)
>Sender: netbsd-bugs-owner@NetBSD.org
>Precedence: list
>
>>Number: 29008
>>Category: xsrc
>>Synopsis: src/11/Xserver/cfb/Makefile.cfb doesn't use optional STIPPLE_CODE
>>Confidential: no
>>Severity: non-critical
>>Priority: low
>>Responsible: xsrc-manager
>>State: open
>>Class: change-request
>>Submitter-Id: net
>>Arrival-Date: Wed Jan 19 09:37:00 +0000 2005
>>Originator: Izumi Tsutsui
>>Release: NetBSD 2.99.14
>>Organization:
>>Environment:
>System: NetBSD 2.99.14 (AIRTREK) #203: Wed Jan 19 01:24:18 JST 2005
>Architecture: mipseb
>Machine: sgimips, and sparc is also affected
>>Description:
>While xsrc/xfree/xc/programs/Xserver/cfb/Imakefile.inc has definitions
>for mips and sparc to use optional STIPPLE_CODE stipsparc.s and stipmips.s,
>src/11/Xserver/cfb/Makefile.cfb doesn't use them.
>Both builds under xsrc and src/x11 should be consistent.
>
>>How-To-Repeat:
>Code inspection.
>
>>Fix:
>Enable STIPPLE_CODE in src/11/Xserver/cfb/Makefile.cfb
>if this option is actually worth. Otherwise, disable them in
>rc/xfree/xc/programs/Xserver/cfb/Imakefile.inc.
>---
>
>
This once was Keith Packard's original cfb rewrite (from about `90),
and some of his later machine specific updates (the mips code targeted the
original r3000 DecStations and later the NCD X-terminals, when he worked
there). Unfortunately the XFree people basically broke it seriously (I admit
that I haven't checked this code at all in over a year); But I doubt it has
much residual value, though a check of change log entries should tell if anyone
believes it has been fixed in the past few years (it was *very* busted a few
years ago - someone who really didn't understand that bad assembler is worse
than good 'C' totally trashed it).
Paul Shupak