Subject: Re: kern/29113: re(4) reports "unknown subtype"
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Masanori Kanaoka <kanaoka@ann.hi-ho.ne.jp>
List: netbsd-bugs
Date: 01/25/2005 12:24:01
The following reply was made to PR kern/29113; it has been noted by GNATS.
From: Masanori Kanaoka <kanaoka@ann.hi-ho.ne.jp>
To: yamt@mwd.biglobe.ne.jp
Cc: gnats-bugs@netbsd.org, kanaoka@ann.hi-ho.ne.jp
Subject: Re: kern/29113: re(4) reports "unknown subtype"
Date: Tue, 25 Jan 2005 21:22:34 +0900 (JST)
----Security_Multipart(Tue_Jan_25_21_22_34_2005_657)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi,
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Subject: Re: kern/29113: re(4) reports "unknown subtype"
Date : Tue, 25 Jan 2005 20:55:56 +0900
Message-ID: <1106654156.513559.745.nullmailer@yamt.dyndns.org>
$ i have to admit i don't know anything about phy/mii.
$ (that's why i filed this PR rather than fix it by myself. :-)
I don't know anything about phy/mii, too. :-)
re and rtk has same code.So I suspect phy/mii.
I only checked difference between ukphy and rgephy.
$ only reason i thought RTK_ENABLED should be checked is the fact that
$ my favorite driver, fxp, does the similar. (fxp_mii_mediastatus)
tlp does the similar.
I also check next patch and confirmed that it fixed this problem.
---
Masanori Kanaoka kanaoka AT ann.hi-ho.ne.jp
Index: rtl8169.c
===================================================================
RCS file: /ftp/cvs/src/sys/dev/ic/rtl8169.c,v
retrieving revision 1.6
diff -u -r1.6 rtl8169.c
--- rtl8169.c 13 Jan 2005 14:24:24 -0000 1.6
+++ rtl8169.c 25 Jan 2005 10:21:10 -0000
@@ -1930,11 +1930,15 @@
sc = ifp->if_softc;
+ if (RTK_IS_ENABLED(sc) == 0) {
+ ifmr->ifm_active = IFM_ETHER | IFM_NONE;
+ ifmr->ifm_status = 0;
+ return;
+ }
+
mii_pollstat(&sc->mii);
ifmr->ifm_active = sc->mii.mii_media_active;
ifmr->ifm_status = sc->mii.mii_media_status;
-
- return;
}
static int
----Security_Multipart(Tue_Jan_25_21_22_34_2005_657)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (NetBSD)
iQEVAwUAQfY6CqZTiBfoL27MAQLUHAgAo6CDnjDe1M0g5Fx7aeEMdWRAkQ8//op9
shXjSFlGSjAT9PaTRulv3OP6mSJfVmz5ok9ui6Ts5jBCYo0V4ztJYN6acO1ODF7D
AgWr2jZ/O15TQ5okwiG16XhHxJN7pXs7UxB5I3d7yknHUT0zd3yPF5XsNT8A39SO
fCE27DKuXp/uvu3TWbz7zs2VlQYPoZpYg8lLt+wADNZ5oFnDQcUu9mtgSbNplaNu
ACryjkhOAc/zgRQPBq9pS9N5QmJ4gHYN6egCRyu7xjZOWHV6ihQDbYNjw+b7XY/P
E+xb1aMg7MZJzq10z+MxE4S+RR6/8EOu2aiiERpsV18ZbDTrWDL0Sw==
=Rx3R
-----END PGP SIGNATURE-----
----Security_Multipart(Tue_Jan_25_21_22_34_2005_657)----