Subject: PR/29133 CVS commit: src/sys
To: None <cube@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org>
From: Quentin Garnier <cube@netbsd.org>
List: netbsd-bugs
Date: 02/15/2005 21:10:02
The following reply was made to PR kern/29133; it has been noted by GNATS.
From: Quentin Garnier <cube@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/29133 CVS commit: src/sys
Date: Tue, 15 Feb 2005 21:09:57 +0000 (UTC)
Module Name: src
Committed By: cube
Date: Tue Feb 15 21:09:57 UTC 2005
Modified Files:
src/sys/ddb: db_sym.c
src/sys/kern: kern_ksyms.c
src/sys/sys: ksyms.h
Log Message:
The way I handled /dev/ksyms requests vs. kernel requests was completely
broken. Inside the kernel, we always have to use the real values of the
st_name fields, and only do the math when the request comes from userland.
No need for ksyms_getval_from{kernel,userland} hack anymore. However, a
different version will be asked for pull-up in -2{,-0}, one that doesn't
break the API, that is.
Fixes PR#29133 from Jens Kessmeier.
To generate a diff of this commit:
cvs rdiff -r1.47 -r1.48 src/sys/ddb/db_sym.c
cvs rdiff -r1.21 -r1.22 src/sys/kern/kern_ksyms.c
cvs rdiff -r1.8 -r1.9 src/sys/sys/ksyms.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.