Subject: PR/28183 CVS commit: [netbsd-2] src/lib/libc/gen
To: None <lib-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Jeff Rizzo <riz@netbsd.org>
List: netbsd-bugs
Date: 05/13/2005 18:27:01
The following reply was made to PR lib/28183; it has been noted by GNATS.
From: Jeff Rizzo <riz@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/28183 CVS commit: [netbsd-2] src/lib/libc/gen
Date: Fri, 13 May 2005 18:26:09 +0000 (UTC)
Module Name: src
Committed By: riz
Date: Fri May 13 18:26:09 UTC 2005
Modified Files:
src/lib/libc/gen [netbsd-2]: getttyent.c
Log Message:
Pull up revision 1.21 (requested by is in ticket #1396):
PR/28183: Brian Marcotte: Getty eats the last character of the last field.
As Brian reports the bug is in skip(). The logic on end of line is broken.
- fix the bug which can cause buf[-1] to be written.
- don't leave the line buffer allocated on end of file.
- KNF
- use __func__ instead of hard-coding the function name.
- don't use needlessly global variables
To generate a diff of this commit:
cvs rdiff -r1.20 -r1.20.4.1 src/lib/libc/gen/getttyent.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.