Subject: Re: bin/30658: 3.0_BETA: pkg_add broken for installing valid binary
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org>
From: Hubert Feyrer <hubert@feyrer.de>
List: netbsd-bugs
Date: 07/13/2005 02:17:02
The following reply was made to PR bin/30658; it has been noted by GNATS.
From: Hubert Feyrer <hubert@feyrer.de>
To: gnats-bugs@netbsd.org, rh@NetBSD.org, wiz@NetBSD.org
Cc: Hubert Feyrer <hubert@feyrer.de>
Subject: Re: bin/30658: 3.0_BETA: pkg_add broken for installing valid binary
pkgs
Date: Wed, 13 Jul 2005 04:15:52 +0200 (CEST)
After previous discussion with wiz@ on the matter in this PR, and PR
pkg/24712 which initially raised the problematic change, I'd like to
change the fatal error into a warning.
Please review, I'll commit this by monday morning GMT if I hear no
objections.
- Hubert
Index: perform.c
===================================================================
RCS file: /cvsroot/src/usr.sbin/pkg_install/add/perform.c,v
retrieving revision 1.110
diff -u -r1.110 perform.c
--- perform.c 29 Jun 2005 01:40:42 -0000 1.110
+++ perform.c 13 Jul 2005 02:09:57 -0000
@@ -408,17 +408,8 @@
if (buildinfo[BI_IGNORE_RECOMMENDED] != NULL &&
strcasecmp(buildinfo[BI_IGNORE_RECOMMENDED], "NO") != 0) {
- warnx("Package `%s' has", pkg);
- warnx("IGNORE_RECOMMENDED set: This package was built with");
- warnx("dependency recommendations ignored. It may have been");
- warnx("built against a set of installed packages that is");
- warnx("different from the recommended set of pre-requisites.");
- warnx("As a consequence, this package may not work on this");
- warnx("or other systems with a different set of packages.");
- if (!Force && !getenv("PKG_IGNORE_RECOMMENDED")) {
- warnx("aborting.");
- goto bomb;
- }
+ warnx("%s was built", pkg);
+ warnx("\t to ignore recommended dependencies, this may cause problems!\n");
}
/*
Index: pkg_add.1
===================================================================
RCS file: /cvsroot/src/usr.sbin/pkg_install/add/pkg_add.1,v
retrieving revision 1.59
diff -u -r1.59 pkg_add.1
--- pkg_add.1 6 May 2005 23:02:39 -0000 1.59
+++ pkg_add.1 13 Jul 2005 02:09:57 -0000
@@ -17,7 +17,7 @@
.\"
.\" @(#)pkg_add.1
.\"
-.Dd May 7, 2005
+.Dd July 13, 2005
.Dt PKG_ADD 1
.Os
.Sh NAME
@@ -401,12 +401,7 @@
is then checked for
.Ev IGNORE_RECOMMENDED .
If the package was built with dependency recommendations ignored,
-installation will be aborted.
-This behavior is overridable with the
-.Fl f
-flag and the
-.Ev PKG_IGNORE_RECOMMENDED
-environment variable.
+a warning will be issued.
.It
If the package contains a
.Ar require