Subject: Re: xsrc/30808
To: None <xsrc-manager@netbsd.org, gnats-admin@netbsd.org,>
From: Matthias Scheler <tron@NetBSD.org>
List: netbsd-bugs
Date: 07/21/2005 21:50:01
The following reply was made to PR xsrc/30808; it has been noted by GNATS.

From: Matthias Scheler <tron@NetBSD.org>
To: xorix@free.fr
Cc: NetBSD GNATS <gnats-bugs@netbsd.org>
Subject: Re: xsrc/30808
Date: Thu, 21 Jul 2005 22:49:31 +0100

 On Thu, Jul 21, 2005 at 10:46:53PM +0200, xorix@free.fr wrote:
 > --- /usr/oxsrc/xfree86/xc/programs/xsm/choose.c 2005-07-21 19:42:44.000000000
 > +0200
 > +++ /usr/xsrc/xfree86/xc/programs/xsm/choose.c  2005-07-21 20:12:08.000000000
 > +0200
 > @@ -209,7 +209,7 @@
 >  Bool highlight;
 > 
 >  {
 > -    if (number >= 0)
 > +    if (sessionsLocked && number >= 0)
 >      {
 >         Bool locked = sessionsLocked[number];
 
 This patch looks wrong. "sessionsLocked" is used at various other locations in the
 code without checking whether it is a NULL pointer. This change is very likely
 only masking the real problem.
 
 Please provide instructions how to reproduce the problem as "xsm" doesn't show a
 "chooseSessionListWidget" button by default.
 
 	Kind regards
 
 -- 
 Matthias Scheler                                  http://scheler.de/~matthias/