Subject: Re: port-m68k/30924: m68k copyinout_t breakage
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: netbsd-bugs
Date: 08/06/2005 14:56:03
The following reply was made to PR port-m68k/30924; it has been noted by GNATS.
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
To: cube@cubidou.net
Cc: gnats-bugs@netbsd.org, port-m68k-maintainer@netbsd.org,
gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: port-m68k/30924: m68k copyinout_t breakage
Date: Sat, 06 Aug 2005 23:55:09 +0900
> > - reconsider if copyinout_t is a good idea or not.
>
> That's irrelevant.
well, it's relevant because there is no need to fix it
if the changes will be backed out. :)
i think it's better to have separate types for in and out,
at least.
> > - restructure headers?
>
> I have two options:
>
> - put copyinout_t in its own header, and include it when needed
> - put copyinout_t in types.h
>
> Tell me which one you prefer.
i read the XXX-cube comment but i'm still not sure
why it can't be in systm.h.
if it's due to circular dependencies among headers, how about
fixing them instead?
eg. move the in-kernel function prototypes including timer_create1
out of time.h so that they won't be included by "primitive" ones?
YAMAMOTO Takashi