Subject: Re: port-m68k/30924: m68k copyinout_t breakage
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: Quentin Garnier <cube@cubidou.net>
List: netbsd-bugs
Date: 08/06/2005 15:05:06
The following reply was made to PR port-m68k/30924; it has been noted by GNATS.
From: Quentin Garnier <cube@cubidou.net>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: gnats-bugs@netbsd.org
Subject: Re: port-m68k/30924: m68k copyinout_t breakage
Date: Sat, 6 Aug 2005 17:04:13 +0200
--FEz7ebHBGB6b2e8X
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 06, 2005 at 11:55:09PM +0900, YAMAMOTO Takashi wrote:
> > > - reconsider if copyinout_t is a good idea or not.
> >=20
> > That's irrelevant.
>=20
> well, it's relevant because there is no need to fix it
> if the changes will be backed out. :)
Heh. I don't feel comfortable having the full types in the other
prototypes :)
> i think it's better to have separate types for in and out,
> at least.
Why? They have the same prototype, and I don't see any reason why
that would change. They're basically the same function, and the name
decides the direction.
OTOH, that would make prototypes that use the type clear about which
direction is used, although there would be no way of enforcing it.
> > > - restructure headers?
> >=20
> > I have two options:
> >=20
> > - put copyinout_t in its own header, and include it when needed
> > - put copyinout_t in types.h
> >=20
> > Tell me which one you prefer.
>=20
> i read the XXX-cube comment but i'm still not sure
> why it can't be in systm.h.
Because of the clockframe nonsense on i386/amd64. I don't know if any
other arch do that, I only use those two, but that would not be entirely
surprising.
> if it's due to circular dependencies among headers, how about
> fixing them instead?
It's really not my area.
> eg. move the in-kernel function prototypes including timer_create1
> out of time.h so that they won't be included by "primitive" ones?
That's a possibility. I'd rather keep things simple, I will certainly
not be volunteering to fix all the kernel include crappiness just to
have copyinout_t declared in a decent way.
--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
--FEz7ebHBGB6b2e8X
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
iQEVAwUBQvTRbdgoQloHrPnoAQLwEwf/Wc+h2eWtTNn53BDY0Gle3pOC3eaxU+af
7Ig/+dxuODnrSVCtQaKBtfS/dox3bW5yD44C1/AglYpQT+dGLFzNfxT2VeF4ou6W
lyGR2PY5elHhPUNklouAdOdsMMGuBF1gY8ZVYjE/QPdbhEGMkDymaWNmCx0OFmd2
fZBDonUjrp+THnrcM7vNLbmCwwxJ1+qHf6rgM5DZFBIIONuAj34DCjn7JqtdatLr
Nk+tioF/MnK9s/uoHaE+bbdSzHz6MSO52Ye6filrxCRDHtYHZQzbal5cfPMc7SZX
W1Y54KxIMdZnB94Z6zST8zp5DF3GuPtKW9P/8wWM6FPBa4rb3Z+30A==
=ev7T
-----END PGP SIGNATURE-----
--FEz7ebHBGB6b2e8X--