Subject: Re: port-m68k/30924: m68k copyinout_t breakage
To: None <port-m68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: Quentin Garnier <cube@cubidou.net>
List: netbsd-bugs
Date: 08/12/2005 07:58:02
The following reply was made to PR port-m68k/30924; it has been noted by GNATS.
From: Quentin Garnier <cube@cubidou.net>
To: Christos Zoulas <christos@zoulas.com>
Cc: gnats-bugs@netbsd.org, yamt@netbsd.org
Subject: Re: port-m68k/30924: m68k copyinout_t breakage
Date: Fri, 12 Aug 2005 09:57:01 +0200
--T/yvDUeUQRtJzDrt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 06, 2005 at 07:35:37PM -0400, Christos Zoulas wrote:
> On Aug 6, 2:09pm, cube@cubidou.net (Quentin Garnier) wrote:
> -- Subject: Re: port-m68k/30924: m68k copyinout_t breakage
>=20
> | That's irrelevant.
> | =20
> | > - restructure headers?
> | =20
> | I have two options:
> | =20
> | - put copyinout_t in its own header, and include it when needed
> | - put copyinout_t in types.h
>=20
> There is also the:
> - fix clockframe #define abuse so that it can be put in <system.h>
So, that part is fixed, but yamt says it's a bad idea to have systm.h
included from time.h.
types.h looks reasonable to me. I don't want to move timer_create1's
prototype away as it would only solve the issue for that one, although
it might reproduce with another header.
Index: types.h
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/src/sys/sys/types.h,v
retrieving revision 1.67
diff -u -r1.67 types.h
--- types.h 22 May 2005 12:44:24 -0000 1.67
+++ types.h 12 Aug 2005 07:55:47 -0000
@@ -320,4 +320,9 @@
#endif
#endif
=20
+#if defined(_KERNEL)
+typedef int (*copyin_t)(const void *, void *, size_t);
+typedef int (*copyout_t)(const void *, void *, size_t);
+#endif
+
#endif /* !_SYS_TYPES_H_ */
--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.
--T/yvDUeUQRtJzDrt
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)
iQEVAwUBQvxWTdgoQloHrPnoAQJawwgAnkDY6nPiSK+U1N2bUOOQvqD5mYpUAw8v
OuldHH3vXu06LFUNzeKYK0vDyK0qnpbmm2W1e/YRydFlLkQmcPu1szmDmKZB03Jh
hpFjYk+yhGzT9GepjUjpELoODwwvZDTydeFeK++rzE7dx2Hjl4fxj3Sk50TQ0maE
reetMDIPCbmZEeQ34Utaz88wxbbn31oq+BhL2TF8/N3S4alBwHyEPrt8S7VVabHZ
Cw79oxYu9gYK7xPXmG9ugNqOEtvRpDWvq1vFuiwGfe5kEXCQT64p+JLJ80bO6A1a
U+r57+HuwRCezADKFUe9DORt7ev1nJjDskElAMl/aoyZaWqvd7P22Q==
=kUBP
-----END PGP SIGNATURE-----
--T/yvDUeUQRtJzDrt--