Subject: Re: kern/15364
To: None <chs@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org>
From: Chuck Silvers <chuq@chuq.com>
List: netbsd-bugs
Date: 09/08/2005 17:21:01
The following reply was made to PR kern/15364; it has been noted by GNATS.
From: Chuck Silvers <chuq@chuq.com>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: gnats-bugs@NetBSD.org
Subject: Re: kern/15364
Date: Thu, 8 Sep 2005 10:20:25 -0700
On Thu, Sep 08, 2005 at 05:24:51AM +0900, YAMAMOTO Takashi wrote:
> > the patch that you sent earlier looks good, I'd just change the
> > "multiple write resid" check into a KASSERT instead of UVMHIST_LOG.
> > same for the "no page" panic.
>
> "multiple write" here is normal if the page is re-dirtied.
> it's the reason why we need a bitmap rather than a byte-count.
oh... yea, for some reason I was thinking you were setting them again if
the page was dirtied again... nevermind.
I'd be good if you added a comment describing exactly how you're using
the b_resid field, since it's different that all other uses, and even
those of us familiar with the code get confused if we're not paying
attention. :-)
-Chuck