Subject: Re: kern/31304: sk and rtk don't contribute to random pool [patch included]
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Rui Paulo <rpaulo@NetBSD.org>
List: netbsd-bugs
Date: 09/12/2005 20:55:01
The following reply was made to PR kern/31304; it has been noted by GNATS.

From: Rui Paulo <rpaulo@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/31304: sk and rtk don't contribute to random pool [patch included]
Date: Mon, 12 Sep 2005 21:51:56 +0100

 --/3yNEOqWowh/8j+e
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On 2005.09.12 20:20:00 +0000, Rhialto wrote:
 | >Number:         31304
 | >Category:       kern
 | >Synopsis:       sk and rtk don't contribute to random pool [patch includ=
 ed]
 | >Confidential:   no
 | >Severity:       non-critical
 | >Priority:       medium
 | >Responsible:    kern-bug-people
 | >State:          open
 | >Class:          change-request
 | >Submitter-Id:   net
 | >Arrival-Date:   Mon Sep 12 20:20:00 +0000 2005
 | >Originator:     Rhialto
 | >Release:        NetBSD 2.0.2 and -current
 | >Organization:
 | =09
 | >Environment:
 | =09
 | =09
 | 	System: NetBSD radl.falu.nl 2.0.2 NetBSD 2.0.2 (Radls Doordringend
 | 	Onjuiste Akkoord) #4: Thu Jun 16 20:52:36 CEST 2005
 | 	rhialto@radl.falu.nl:/usr/src/sys/arch/amd64/compile/RADL amd64
 | 	Architecture: x86_64 Machine: amd64
 | >Description:
 | 	None of the network interfaces (sk and rtk) on my machine contribute
 | 	to the randomness pool. Some other network interfaces exist that do,
 | 	such as vr, so I did a cut and paste job for both 2.0.2 and -current.
 | 	From code inspection it seems that in -current rtk should work
 | 	already. sk has partial code that can't (and doesn't) work.
 |=20
 | >How-To-Repeat:
 | 	run `rndctl -ls' and see there are no network sources listed.
 | >Fix:
 | 	First the patch for 2.0.2, then for -current.
 | 	I compile-tested the one for 2.0.2, then cut&pasted where needed
 | 	to my cvs tree to generate the version for -current.
 
 I think the patch looks good, but you should prefix variables in the
 'sc' struct with 'sc' as it's already done, i.e. sc_rnd_source.
 
 		-- Rui Paulo
 
 --/3yNEOqWowh/8j+e
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.2 (NetBSD)
 
 iD8DBQFDJepsZPqyxs9FH4QRAovMAJ9Q+lErRNqzIuZxRzxZmHnc4BFwsgCgkuez
 ZdAITI7IfrQlKUA7ZV8UQBw=
 =Zuaq
 -----END PGP SIGNATURE-----
 
 --/3yNEOqWowh/8j+e--