Subject: bin/31497: rc.d/accounting should have KEYWORD: shutdown
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org>
From: None <kre@munnari.OZ.AU>
List: netbsd-bugs
Date: 10/07/2005 01:19:00
>Number:         31497
>Category:       bin
>Synopsis:       rc.d/accounting should have KEYWORD: shutdown
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 07 01:19:00 +0000 2005
>Originator:     Robert Elz
>Release:        NetBSD 2.0.* (and NetBSD-3 and -current)
>Organization:
	Prince of Songkla University
>Environment:
	The following is irrelevant:
System: NetBSD delta.noi.kre.to 2.0.1 NetBSD 2.0.1 (DELTA-1.11-20050129) #1: Sat Jan 29 15:31:14 ICT 2005 kre@lilac.noi.kre.to:/usr/obj/2.0/kernels/DELTA i386
Architecture: i386
Machine: i386
>Description:
	If process accounting is configured with the accounting file on a
	"device" that is disabled during the shutdown sequence (like
	raidframe), then the device gets removed during shutdown, while
	accounting is still running, causing the kernel to emit a message
	about an I/O error on the acocunting file.

	This is harmless, but annoying.

>How-To-Repeat:
	Configure accounting on a raidframe device (with do_rcshutdown=YES
	of course), and shutdown the system, watching the console as it
	shuts down.    Expect an error from the acocunting system.

>Fix:
	Add
		# KEYWORD: shutdown
	to /etc/rc.d/accounting (src/etc/rc.d/accounting) so the accounting
	gets disabled before raidframs (and anything similar) gets
	terminated.

	ps: someone might want to consider whether rc.d/swap2 needs the
	shutdown keyword as well - I don't much care, I don't swap onto
	non-block devices (ie: files) and don't know anyone who does.