Subject: Re: kern/31963: Wrong VIA Technologies VT82C686A SMBus Controller in pcidevs
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Nicolas Joly <njoly@pasteur.fr>
List: netbsd-bugs
Date: 11/01/2005 07:32:02
The following reply was made to PR kern/31963; it has been noted by GNATS.
From: Nicolas Joly <njoly@pasteur.fr>
To: gnats-bugs@NetBSD.org
Cc: Nicolas Joly <njoly@pasteur.fr>
Subject: Re: kern/31963: Wrong VIA Technologies VT82C686A SMBus Controller in pcidevs
Date: Tue, 1 Nov 2005 08:31:44 +0100
--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Mon, Oct 31, 2005 at 11:00:05PM +0000, Pavel Cahyna wrote:
> The following reply was made to PR kern/31963; it has been noted by GNATS.
>
> From: Pavel Cahyna <pcah8322@artax.karlin.mff.cuni.cz>
> To: gnats-bugs@netbsd.org
> Cc: njoly@pasteur.fr
> Subject: Re: kern/31963: Wrong VIA Technologies VT82C686A SMBus Controller in pcidevs
> Date: Mon, 31 Oct 2005 23:58:48 +0100
>
> On Mon, Oct 31, 2005 at 10:49:01PM +0000, njoly@pasteur.fr wrote:
> > - * The VIA VT82C686A SMBus Controller itself as
> > - * ISA bridge, but it's wrong !
> > + * The VIA VT82C686A SMBus Power Management
> > + * identifies itself as ISA bridge, but it's wrong !
>
> > - * The VIA VT82C686A SMBus Controller itself as
> > - * ISA bridge, but it's wrong !
> > + * The VIA VT82C686A Power Management Controller
> > + * identifies itself as ISA bridge, but it's wrong !
>
> Your patch isn't consistent.
Oops. Thanks for noticing it. Attached an updated version.
--
Nicolas Joly
Biological Software and Databanks.
Institut Pasteur, Paris.
--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="netbsd-viapwr.diff"
Index: sys/arch/amd64/pci/pcib.c
===================================================================
RCS file: /cvsroot/src/sys/arch/amd64/pci/pcib.c,v
retrieving revision 1.4
diff -u -r1.4 pcib.c
--- sys/arch/amd64/pci/pcib.c 30 Aug 2004 15:05:16 -0000 1.4
+++ sys/arch/amd64/pci/pcib.c 1 Nov 2005 07:12:39 -0000
@@ -152,10 +152,10 @@
break;
case PCI_VENDOR_VIATECH:
switch (PCI_PRODUCT(pa->pa_id)) {
- case PCI_PRODUCT_VIATECH_VT82C686A_SMB:
+ case PCI_PRODUCT_VIATECH_VT82C686A_PWR:
/*
- * The VIA VT82C686A SMBus Controller itself as
- * ISA bridge, but it's wrong !
+ * The VIA VT82C686A Power Management Controller
+ * identifies itself as ISA bridge, but it's wrong !
*/
return (0);
}
Index: sys/arch/i386/pci/pcib.c
===================================================================
RCS file: /cvsroot/src/sys/arch/i386/pci/pcib.c,v
retrieving revision 1.36
diff -u -r1.36 pcib.c
--- sys/arch/i386/pci/pcib.c 26 Jun 2005 02:09:59 -0000 1.36
+++ sys/arch/i386/pci/pcib.c 1 Nov 2005 07:13:19 -0000
@@ -149,10 +149,10 @@
break;
case PCI_VENDOR_VIATECH:
switch (PCI_PRODUCT(pa->pa_id)) {
- case PCI_PRODUCT_VIATECH_VT82C686A_SMB:
+ case PCI_PRODUCT_VIATECH_VT82C686A_PWR:
/*
- * The VIA VT82C686A SMBus Controller itself as
- * ISA bridge, but it's wrong !
+ * The VIA VT82C686A Power Management Controller
+ * identifies itself as ISA bridge, but it's wrong !
*/
return (0);
}
Index: sys/arch/xen/xen/pcib.c
===================================================================
RCS file: /cvsroot/src/sys/arch/xen/xen/pcib.c,v
retrieving revision 1.2
diff -u -r1.2 pcib.c
--- sys/arch/xen/xen/pcib.c 9 Mar 2005 22:39:21 -0000 1.2
+++ sys/arch/xen/xen/pcib.c 1 Nov 2005 07:14:09 -0000
@@ -150,10 +150,10 @@
break;
case PCI_VENDOR_VIATECH:
switch (PCI_PRODUCT(pa->pa_id)) {
- case PCI_PRODUCT_VIATECH_VT82C686A_SMB:
+ case PCI_PRODUCT_VIATECH_VT82C686A_PWR:
/*
- * The VIA VT82C686A SMBus Controller itself as
- * ISA bridge, but it's wrong !
+ * The VIA VT82C686A Power Management Controller
+ * identifies itself as ISA bridge, but it's wrong !
*/
return (0);
}
Index: sys/dev/pci/pcidevs
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pcidevs,v
retrieving revision 1.733
diff -u -r1.733 pcidevs
--- sys/dev/pci/pcidevs 5 Oct 2005 00:43:58 -0000 1.733
+++ sys/dev/pci/pcidevs 1 Nov 2005 07:14:59 -0000
@@ -2968,7 +2968,7 @@
product VIATECH VT82C586_PWR 0x3040 VT82C586 Power Management Controller
product VIATECH VT3043 0x3043 VT3043 (Rhine) 10/100 Ethernet
product VIATECH VT6306 0x3044 VT6306 IEEE 1394 Host Controller
-product VIATECH VT82C686A_SMB 0x3057 VT82C686A SMBus Controller
+product VIATECH VT82C686A_PWR 0x3057 VT82C686A Power Management Controller
product VIATECH VT82C686A_AC97 0x3058 VT82C686A AC-97 Audio Controller
product VIATECH VT8233_AC97 0x3059 VT8233/VT8235 AC-97 Audio Controller
product VIATECH VT6102 0x3065 VT6102 (Rhine II) 10/100 Ethernet
Index: sys/dev/pci/viapm.c
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/viapm.c,v
retrieving revision 1.13
diff -u -r1.13 viapm.c
--- sys/dev/pci/viapm.c 14 Sep 2004 18:57:35 -0000 1.13
+++ sys/dev/pci/viapm.c 1 Nov 2005 07:16:13 -0000
@@ -70,7 +70,7 @@
return 0;
switch (PCI_PRODUCT(pa->pa_id)) {
- case PCI_PRODUCT_VIATECH_VT82C686A_SMB:
+ case PCI_PRODUCT_VIATECH_VT82C686A_PWR:
#ifdef notyet
case PCI_PRODUCT_VIATECH_VT8231_PWR:
#endif
--fUYQa+Pmc3FrFX/N--