Subject: Re: port-mips/31915: provide centralized wired_map logic
To: None <tsutsui@netbsd.org, gnats-admin@netbsd.org,>
From: Garrett D'Amore <garrett_damore@tadpole.com>
List: netbsd-bugs
Date: 11/01/2005 16:24:01
The following reply was made to PR port-mips/31915; it has been noted by GNATS.
From: "Garrett D'Amore" <garrett_damore@tadpole.com>
To: SODA Noriyuki <soda@sra.co.jp>
Cc: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>, gnats-bugs@NetBSD.org,
port-mips@NetBSD.org
Subject: Re: port-mips/31915: provide centralized wired_map logic
Date: Tue, 01 Nov 2005 08:23:13 -0800
SODA Noriyuki wrote:
>"Garrett D'Amore" <garrett_damore@tadpole.com> wrote:
>
>
>> >- pagemask for wired maps should be defined in machine dependent headers,
>> > or maybe it should be passed from callers.
>>
>> I don't like passing it from callers, because I don't want it to be
>> variable. (This would make the code a lot more complex to make sure it
>> was correct and you didn't have overlapping maps, etc.) But defining
>> it in the machine dependent header seems reasonable.
>>
>>
>
>If we'll provide an implementation which is reusable from various
>ports, pagemask should be passed from callers.
>ARC port needs it.
>--
>soda
>
>
It seems to me that we need to do this. I'd prefer to also have a
wrapper function which doesn't require the pagemask, so that the detail
of the MMU pagemasks can be hidden from the caller unless the caller
needs it.
I'll tweak it slightly and send a diff shortly.
-- Garrett