Subject: Re: kern/23276
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Jason Thorpe <thorpej@shagadelic.org>
List: netbsd-bugs
Date: 11/22/2005 17:35:01
The following reply was made to PR kern/23276; it has been noted by GNATS.
From: Jason Thorpe <thorpej@shagadelic.org>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org
Subject: Re: kern/23276
Date: Tue, 22 Nov 2005 09:33:59 -0800
On Nov 22, 2005, at 7:50 AM, Izumi Tsutsui wrote:
> Index: sys/dev/pci/ahc_pci.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/pci/ahc_pci.c,v
> retrieving revision 1.51
> diff -u -r1.51 ahc_pci.c
> --- sys/dev/pci/ahc_pci.c 28 Jun 2005 00:28:41 -0000 1.51
> +++ sys/dev/pci/ahc_pci.c 20 Oct 2005 15:46:25 -0000
> @@ -1042,6 +1042,9 @@
> printf("%s: Using left over BIOS settings\n",
> ahc_name(ahc));
> ahc->flags &= ~AHC_USEDEFAULTS;
> +#ifdef AHC_IGNORE_BIOSTARGETSETTINGS
> + ahc->flags |= AHC_DEFAULTTARGETCONF;
> +#endif
> ahc->flags |= AHC_BIOS_ENABLED;
> } else {
> /*
Wouldn't it be better to use a device property here rather than an
#ifdef?
-- thorpej