Subject: kern/32166: pgo_get protocol is ambiguous
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <yamt@mwd.biglobe.ne.jp>
List: netbsd-bugs
Date: 11/26/2005 15:45:00
>Number:         32166
>Category:       kern
>Synopsis:       pgo_get protocol is ambiguous
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 26 15:45:00 +0000 2005
>Originator:     YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
>Release:        NetBSD 3.99.10
>Organization:

>Environment:
	
	
System: NetBSD kaeru 3.99.10 NetBSD 3.99.10 (build.kaeru.xen.nodebug) #22: Wed Nov 2 06:33:38 JST 2005 takashi@kaeru:/home/takashi/work/kernel/build.kaeru.xen.nodebug i386
Architecture: i386
Machine: i386
>Description:
	pgo_get of each pagers behaves somewhat differently.

	1. uvn_get ignores PGO_ALLPAGES.
	   uao_get alters its return value with it.

	2. in the case of !PGO_LOCKED, uvn_get ignores PGO_DONTCARE,
	   while uao_get honours it.

>How-To-Repeat:
	code inspection.
>Fix:
	i'd propose to:

	1. deprecate PGO_ALLPAGES for pgo_get because
	   it doesn't seem to make much sense.

	2. for !PGO_LOCKED requests, always ignore PGO_DONTCARE.
	   (ie. make "pps" output only, and remove memset() in callers.)

>Unformatted: