Subject: kern/32381: dev/ppbus/lpt.c broken after lwp/proc substitution changes
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: None <paul@Plectere.com>
List: netbsd-bugs
Date: 12/25/2005 18:30:01
>Number: 32381
>Category: kern
>Synopsis: /sys/dev/ppbus/lpt.c doesn't build
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: kern-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Dec 25 18:30:01 +0000 2005
>Originator: Paul Shupak
>Release: NetBSD 3.99.15
>Organization:
>Environment:
System: NetBSD svcs 3.99.10 NetBSD 3.99.10 (SVCS) #22: Wed Oct 19 14:35:15 PDT 2005 root@svcs:/sys/arch/i386/compile/SVCS i386
Architecture: i386
Machine: i386
>Description:
The file /usr/src/sys/dev/ppbus/lpt.c still declares (unused) proc
pointers instead of lwp pointers, causing a kernel build to fail.
>How-To-Repeat:
Try to build a kernel with "lpt* at ppbus?"
>Fix:
Trivial patch.
Index: lpt.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ppbus/lpt.c,v
retrieving revision 1.14
diff -c -r1.14 lpt.c
*** lpt.c 11 Dec 2005 12:23:28 -0000 1.14
--- lpt.c 25 Dec 2005 18:12:20 -0000
***************
*** 409,415 ****
* lptopen -- reset the printer, then wait until it's selected and not busy.
*/
int
! lptopen(dev_t dev_id, int flags, int fmt, struct proc *p)
{
int trys, err;
u_int8_t status;
--- 409,415 ----
* lptopen -- reset the printer, then wait until it's selected and not busy.
*/
int
! lptopen(dev_t dev_id, int flags, int fmt, struct lwp *l)
{
int trys, err;
u_int8_t status;
***************
*** 502,508 ****
* Check for interrupted write call added.
*/
int
! lptclose(dev_t dev_id, int flags, int fmt, struct proc *p)
{
struct device * dev = device_lookup(&lpt_cd, LPTUNIT(dev_id));
struct lpt_softc * sc = (struct lpt_softc *) dev;
--- 502,508 ----
* Check for interrupted write call added.
*/
int
! lptclose(dev_t dev_id, int flags, int fmt, struct lwp *l)
{
struct device * dev = device_lookup(&lpt_cd, LPTUNIT(dev_id));
struct lpt_softc * sc = (struct lpt_softc *) dev;
***************
*** 608,614 ****
/* Printer ioctl */
int
! lptioctl(dev_t dev_id, u_long cmd, caddr_t data, int flags, struct proc *p)
{
struct device *dev = device_lookup(&lpt_cd, LPTUNIT(dev_id));
struct lpt_softc *sc = (struct lpt_softc *) dev;
--- 608,614 ----
/* Printer ioctl */
int
! lptioctl(dev_t dev_id, u_long cmd, caddr_t data, int flags, struct lwp *l)
{
struct device *dev = device_lookup(&lpt_cd, LPTUNIT(dev_id));
struct lpt_softc *sc = (struct lpt_softc *) dev;