Subject: PR/32603 CVS commit: xsrc/xfree/xc/programs/xdm
To: None <christos@netbsd.org, gnats-admin@netbsd.org,>
From: Ty Sarna <tsarna@netbsd.org>
List: netbsd-bugs
Date: 01/25/2006 16:35:03
The following reply was made to PR xsrc/32603; it has been noted by GNATS.
From: Ty Sarna <tsarna@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: PR/32603 CVS commit: xsrc/xfree/xc/programs/xdm
Date: Wed, 25 Jan 2006 16:31:21 +0000 (UTC)
Module Name: xsrc
Committed By: tsarna
Date: Wed Jan 25 16:31:21 UTC 2006
Modified Files:
xsrc/xfree/xc/programs/xdm: session.c
Log Message:
Fixes to XDM login handling:
1) PR xsrc/32603 xdm w/ pam_krb5 fails to store tickets
The pam_setcred call was inside an #ifndef HAS_SETUSERCONTEXT block.
What that feature was recently disabled, I stopped getting tickets on
xdm login. Move pam_setcred block outside of and before that block.
(I believe pam_setcred needs to happen before anyway, as it
expects to still be root when called)
2) PR xsrc/31376 xdm loses environment settings from PAM
Setting environment variables from pam needs to happen after
pam_setcred, since environment variables may be set there
(and are, by pam_krb5)
3) no PR, mentioned on lists: default path changed
the setusercontext code was setting the path always, even if no
path was configured in login.conf, so xdm's default path was
always overwritten, even if only by _PATH_DEFPATH.
Now login.conf paths should be used if explicitly set, but xdm's
default path will be used otherwise.
To generate a diff of this commit:
cvs rdiff -r1.2 -r1.3 xsrc/xfree/xc/programs/xdm/session.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.