Subject: Re: port-mac68k/32583: mac68k netbsd-2 panics during rcp(1)
To: None <port-mac68k-maintainer@netbsd.org, gnats-admin@netbsd.org,>
From: Dave Huang <khym@azeotrope.org>
List: netbsd-bugs
Date: 01/25/2006 21:50:02
The following reply was made to PR port-mac68k/32583; it has been noted by GNATS.
From: Dave Huang <khym@azeotrope.org>
To: gnats-bugs@netbsd.org,
Hauke Fath <hauke@Espresso.Rhein-Neckar.DE>
Cc: port-mac68k-maintainer@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: port-mac68k/32583: mac68k netbsd-2 panics during rcp(1)
Date: Wed, 25 Jan 2006 15:46:26 -0600
On Wed, Jan 25, 2006 at 09:25:02PM +0000, Hauke Fath wrote:
> Meaning you'd want
>
> if (!(c)) panic(...)
>
> instead above?
Yes, or to conform to the NetBSD style guide,
if ((c) == 0) panic(...)
However, that doesn't fix the actual bug; it just fixes the DIAGNOSTIC
check so that it'll panic with a useful message instead of getting a
bus error trap.
The actual fix is in the patch to sys/arch/mac68k/dev/if_ae.c that I
sent back on Jan 20:
http://mail-index.netbsd.org/netbsd-bugs/2006/01/20/0032.html