Subject: Re: PR/32676 CVS commit: src/sys/net
To: None <netbsd-bugs@netbsd.org>
From: Rui Paulo <rpaulo@fnop.net>
List: netbsd-bugs
Date: 01/31/2006 23:16:55
Pavel Cahyna <pavel.cahyna@st.mff.cuni.cz> writes:

> The following reply was made to PR kern/32676; it has been noted by GNATS.
>
> From: Pavel Cahyna <pavel.cahyna@st.mff.cuni.cz>
> To: Rui Paulo <rpaulo@fnop.net>
> Cc: gnats-bugs@netbsd.org
> Subject: Re: PR/32676 CVS commit: src/sys/net
> Date: Tue, 31 Jan 2006 23:37:57 +0100
>
>  On Tue, Jan 31, 2006 at 09:30:40PM +0000, Rui Paulo wrote:
>  > Pavel Cahyna <pavel.cahyna@st.mff.cuni.cz> writes:
>  > >  Shouldn't the whole faith(4) be used only with INET6? Why to compile in
>  > >  faith without INET6?
>  > 
>  > I agree. I think I'm going to fix that, if no one objects.
>  
>  conf/files has:
>  
>  file    net/if_faith.c                  faith & inet & inet6    needs-flag
>  
>  does it mean that if_faith.c is compiled only if both inet and inet6 are
>  defined? Isn't this enough?

No, because ioconf.c (generated by config(8)) has faithattach() and
faithattach() doesn't get compiled in if INET6 isn't defined.
The solution is here do something like:

#ifndef INET6
#error "INET6 must be defined to use faith"
#endif

(and stf has the same problem)

-- 
Rui Paulo - rpaulo@fnop.net