Subject: Re: kern/32928: bpf filter can fail to extract a 32-bit quantity
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: David Laight <david@l8s.co.uk>
List: netbsd-bugs
Date: 02/25/2006 14:25:05
The following reply was made to PR kern/32928; it has been noted by GNATS.
From: David Laight <david@l8s.co.uk>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/32928: bpf filter can fail to extract a 32-bit quantity
Date: Sat, 25 Feb 2006 14:29:10 +0000
On Sat, Feb 25, 2006 at 02:10:03PM +0000, Pavel Cahyna wrote:
> + } else {
> + return (m_xhalf(m, k, err) << 16) | m_xhalf(m, k+2, err);
I suspect you really don't want to be doing that unless the data
actually crosses 2 mbuf boundaries.
In which case the correct thing to do is fix the underlying routine.
David
--
David Laight: david@l8s.co.uk