Subject: Re: PR/33392 CVS commit: src/dist/nawk
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,>
From: Aleksey Cheusov <cheusov@tut.by>
List: netbsd-bugs
Date: 06/26/2006 07:20:03
The following reply was made to PR bin/33392; it has been noted by GNATS.
From: Aleksey Cheusov <cheusov@tut.by>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: PR/33392 CVS commit: src/dist/nawk
Date: Mon, 26 Jun 2006 10:19:05 +0300
> | Thanks for applying the patch.
> | Just a minor note:
> | you forgot about xfree(f->gototab[i]) in function 'freefa'.
>
> Thanks,
You also forgot about chaning type of gototab array from uschar to int,
typing it as uschar is another kind of limiting a number of states.
< uschar **gototab;
> int **gototab;
I also found my own mistake
< fa->gototab[i] = calloc(1, NCHARS * sizeof (*fa->gototab));
> fa->gototab[i] = calloc(1, NCHARS * sizeof (**fa->gototab));
--
Best regards, Aleksey Cheusov.