Subject: Re: PR/33392 CVS commit: src/dist/nawk
To: Aleksey Cheusov <cheusov@tut.by>
From: Christos Zoulas <christos@zoulas.com>
List: netbsd-bugs
Date: 06/26/2006 09:11:14
On Jun 26, 10:19am, cheusov@tut.by (Aleksey Cheusov) wrote:
-- Subject: Re: PR/33392 CVS commit: src/dist/nawk

| 
| >  | Thanks for applying the patch.
| >  | Just a minor note:
| >  | you forgot about xfree(f->gototab[i]) in function 'freefa'.
| >  
| >  Thanks,
| 
| You also forgot about chaning type of gototab array from uschar to int,
| typing it as uschar is another kind of limiting a number of states.
| <       uschar  **gototab;
| >       int     **gototab;
| 
| I also found my own mistake
| <               fa->gototab[i] = calloc(1, NCHARS * sizeof (*fa->gototab));
| >               fa->gototab[i] = calloc(1, NCHARS * sizeof (**fa->gototab));
| 

Thanks,

I think int is too wide. I made it unsigned short.

christos