Subject: Re: PR/33392 CVS commit: src/dist/nawk
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,>
From: Aleksey Cheusov <cheusov@tut.by>
List: netbsd-bugs
Date: 07/03/2006 21:35:01
The following reply was made to PR bin/33392; it has been noted by GNATS.
From: Aleksey Cheusov <cheusov@tut.by>
To: christos@zoulas.com (Christos Zoulas)
Cc: gnats-bugs@NetBSD.org, gnats-admin@NetBSD.org,
netbsd-bugs@NetBSD.org
Subject: Re: PR/33392 CVS commit: src/dist/nawk
Date: Tue, 04 Jul 2006 00:35:11 +0300
--=-=-=
> | Changes you commited to the HEAD related to this PR seems good to me,
> | everything works correctly and much faster than gawk (for huge
> | regexps) that i used for years.
> |
> | 1) have you a plan to notify Brian about bug found?
> Someone is already doing this.
good.
> | 2) have you a plan to add an additional regression test for awk?
> No, but I would appreciate it if you created some.
The following patch is relative to netbsd-3 branch.
--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=awk-regress-test.patch
Content-Description: regression test for awk
Index: Makefile
===================================================================
RCS file: /cvsroot/src/regress/usr.bin/awk/Makefile,v
retrieving revision 1.1
diff -u -r1.1 Makefile
--- Makefile 13 Jan 2005 12:26:12 -0000 1.1
+++ Makefile 3 Jul 2006 21:23:37 -0000
@@ -1,5 +1,5 @@
# $NetBSD: Makefile,v 1.1 2005/01/13 12:26:12 yamt Exp $
-SUBDIR+= string1
+SUBDIR+= string1 big-regexp
.include <bsd.subdir.mk>
Index: big-regexp/Makefile
===================================================================
RCS file: big-regexp/Makefile
diff -N big-regexp/Makefile
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ big-regexp/Makefile 3 Jul 2006 21:23:37 -0000
@@ -0,0 +1,13 @@
+# $NetBSD$
+
+NOMAN= # defined
+
+.include <bsd.own.mk>
+
+CLEANFILES= result
+
+regress:
+ ${AWK} -f ${.CURDIR}/test.awk < input > result
+ @cmp ${.CURDIR}/expected result
+
+.include <bsd.prog.mk>
Index: big-regexp/expected
===================================================================
RCS file: big-regexp/expected
diff -N big-regexp/expected
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ big-regexp/expected 3 Jul 2006 21:23:37 -0000
@@ -0,0 +1 @@
+1_NNIFO 1_PSFR 1_JJFO 1_NNIFO 1_INR 1_NNIMR 1_CC 1_NNING 1_RQ 1_VPLIPF 1_NNIFG 1_JJPG 1_NNIMPG 1_PQINO 1_VPIPN 1_PP3FD 1_JJMA 1_PQMO 1_TC 1_VIIR3
Index: big-regexp/input
===================================================================
RCS file: big-regexp/input
diff -N big-regexp/input
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ big-regexp/input 3 Jul 2006 21:23:37 -0000
@@ -0,0 +1 @@
+1_NNIFO 1_PSFR 1_JJFO 1_NNIFO 1_INR 1_NNIMR 1_CC 1_NNING 1_RQ 1_VPLIPF 1_NNIFG 1_JJPG 1_NNIMPG 1_PQINO 1_VPIPN 1_PP3FD 1_JJMA 1_PQMO 1_TC 1_VIIR3
Index: big-regexp/result
===================================================================
RCS file: big-regexp/result
diff -N big-regexp/result
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ big-regexp/result 3 Jul 2006 21:23:37 -0000
@@ -0,0 +1 @@
+1_NNIFO 1_PSFR 1_JJFO 1_NNIFO 1_INR 1_NNIMR 1_CC 1_NNING 1_RQ 1_VPLIPF 1_NNIFG 1_JJPG 1_NNIMPG 1_PQINO 1_VPIPN 1_PP3FD 1_JJMA 1_PQMO 1_TC 1_VIIR3
Index: big-regexp/test.awk
===================================================================
RCS file: big-regexp/test.awk
diff -N big-regexp/test.awk
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ big-regexp/test.awk 3 Jul 2006 21:23:37 -0000
@@ -0,0 +1,3 @@
+# $Id$
+
+/^[^_][^ ]*_NNIFO([ ]+[^_]+[^ ]*_(CC|INR|JJFO|JJMA|JJPG|NNIFG|NNIFO|NNIMPG|NNIMR|NNING|PP3FD|PQINO|PQMO|PSFR|RQ|TC|VIIR3|VPIPN|VPLIPF|NOTAG|RQR))*$/
--=-=-=
What kind of fixes/changes you (NetBSD team) backport to netbsd-2/3 branches?
--
Best regards, Aleksey Cheusov.
--=-=-=--