Subject: bin/34545: cdplay(1): digital transfer mode [PATCH]
To: None <gnats-admin@netbsd.org, netbsd-bugs@netbsd.org>
From: None <svs+pr@grep.ru>
List: netbsd-bugs
Date: 09/17/2006 17:50:00
>Number: 34545
>Category: bin
>Synopsis: cdplay(1): digital transfer mode [PATCH]
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: bin-bug-people
>State: open
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Sep 17 17:50:00 +0000 2006
>Originator: svs+pr@grep.ru
>Release: NetBSD 3.0.1_STABLE
>Organization:
>Environment:
>Description:
cdplay(1) relies on a physical connection between CD drive and audio card;
it may not be not present (USB audio), or be of low quality (noisy).
>How-To-Repeat:
Try playing an audio CD via USB speakers.
>Fix:
be32toh() calls were removed because kernel already does necessary
conversions and delivers CD TOC contents in host order.
begin 644 cdplay-dxfer.diff.gz
M'XL("````````V-D<&QA>2UD:6=I=&%L+F1I9F8`Q3QM>]K&LI_QK]C0)RD8
M@1'@]\0MQ23AU#:^AIR>WC8/E=%B=`,25Q(X:>/_?N=E5UH)3)SDP\US:J3=
MV=G9>=N9V=7I^:[\>"+&[F+F?*J-=UY]_[^=F\Y`3+R9/!%[JV"VU]@;KZ+E
M8B\*QWO+**S=>OX>S[>GI[56.Z&,0T^N//].A/`3>8$O[%JSL>-ZDXFH+D4U
MQ->4TFJUFKP4[(;XE^.+1KU^(.RC$WO_9/]85.OPKT!(*I6*`7PH!G*A@%LG
MK0/X'P/O_/RSJ+:.K0-1@;_'XN>?=\0/GC^>+5TI7D:?HCTO&,>SVO0LWX[K
MW=`\=KT`FRO9YMB;RPW-SA+`-PZ(QI'''<*<PHDB&<;<C*3O'R+I!W7K,$>Z
M#$,_R-$W]:)8NEZ<:YYY<R^.\C2,I]+-K\^[\YTU7L1JQ=FVF7>+C4CCP0'2
M>*AIW!'27\[%>.Z*?W9$H7-Y/NI<]`==:Z="+^>]-[UA^\)2?=U_=3M#_?*V
M>W&MGWM7K_L637#<Q`F.C]0$#V(<^%&,,\3.[1_OQ2N:Z!^18"@4?RI:!2&$
M;8FZ>+"27B:D4!S/@D@6+8:X>G=Q@4`5!:0)+!1=[\Z+G1D``EAQLK@OFLB8
M\D)1_H\<QWED.7JF<K8@D$TPM-)"T?,GP1H,KM^V6Y:]+RIVHV[9S`,U<C#L
M(_8H#A3VYCKV?_<OWEWBHL%TEW-:-:[FY>Q,O`S//L_D)/X<>G?3^/-\&<O/
M\\`//H,>A3+@U3Z<[E3%3O4'5TX\7XI>OS.\&`UZE]<7W=+$M0283[GPYTZU
MX`;B'X$/!6\B2J5P!8(AZTK`RN+LE:B7-5B!Q`"]Y5/5,'%A3-56KP]"SB*I
MNNZ=T"\5&5]1_``_HE@NJI$/XGX*]BI*]?).!=1\*ZT%H+9"U!8*ZH4H9MQ(
MCB5*&7(9QB!7C4KH5>],<(+T49JQ-R%Y;U=T^E>#(?PY%[M[(KN$SOEY&U;P
MW]U"H[G?(&?!/87.^>BR_9_1\*;=^;5P?%P`/#,GO)-@&0U!FBM^Z9P+L,5;
M&0)BY5'L9A/LJ&*W;,MF?^CY,:J.F$<36(U]2BV%:+J<3&92O<%_,G3&L;>2
M#%/!5F4?T%)7+?'MRIEY+K>(*`Z78QB,WC&$#N'%JQ&]`#AW@NE6"LJ>IP[0
MZ2Q]9P[35@K+D6YQG=BQ\.%V.<$>I-B9N/H1#%,_SFZ=410[86S1H_1=?A@O
MPU#Z<0(6W#L`,O7H)Y2.&TGYP1*XG^"3AL-WV,`LI,V_D\F,.&($+C@((VAZ
M(/8)USE%^;P%+QR$G\0NNN-3?N^N8'(QA661"%J'EMT"&1P<:GM&I(6YX_DE
M>+(4*W;+,'PY0KZ";!JPCA*]6<+\*2L1!0OIC]W2*O!`05D:V$1;D&X5!J>%
MV%TX(2@T3V81#;L:&ZZ\9,J%^LW>T>TL&'^(F&#NJR1]2C/,SG0@+";IV/0G
M`QR#VGW8`)X`A?`791XOHPS!"(#+5A",1RG=V!W%P1C4(T9!91E3V%V$P7P1
M9SB)`F=.YBC12JK)(<U(<!-WDJZEEFZ.2C(W&8-_-OE%FG)T:!V)2L-.'3]Z
MJK&+-B)>O2)G7X;6@FX2=S*6_JI4[)Q?7[1_+R)^<)#*UY3&#!'`\L!7C"T!
M?U>XMYU,B^#OGJ$W*Z-W=&ILB`;&]KOS7O^\^V_$62$ZGB5@.&;CH,%UM_UK
M]^9)8XI[KESM1<'2=XNGZ`2_2+9SDB4<&!'=>_%X"CPJDVLIC!W80GYT?CPA
MCVQ.!]@`S2F[]L"//7^)[DX/F<`043`XJ^%%!A[%A/(!G]IH-52(67A`3Z!-
M$M9>+<`T4>CX;C`O@17/`O^NC)ZP1!(D[B!M>D.!U;.H<;GBC'8AG#CKA^M$
MS"0(16D!K^@=D3-C"*1A"#VO*A4<2E0V*`YN'#15(%4`;8V7H2]*J)H03A%?
MD1A>0`6U$I""U;C!,N;0@GK)I":EXO#30HJ_?OI1(`WC8#Z'!8H9.+P__3]]
MUCU10#\(U$W9+X++\N*2TN]&D^+;QF%#DR1G(YBT!.%2'%JB>S'JGO>&_1N0
MM9P[XXAPK@-=W_0OKX?@O\ER-\.\[0V&EJ:"'XCM:X"#WILK"/^$G>`)EN%8
M:@C-!.B#@%G"?)]P_(O(X:VM!@]S)_J@E[A/T6OCZ!@LF;E>*"@J2OAKB1=3
M:8FWH^[5L`L+E;,9;.]EUK,"/@/SP&^YRT4IVP?"@BYVXM@.F$"(9=9HTAX:
M_4R["6HN3$+)X`J-BK+^89P8MK^BN/&_WO6&:J*)DC?H`6QZ((L_0Q8O+1#B
M_V-1:=9;L$Z]P#14HO=$K>'E`<,Y""V6T50I%MG'!GJK:]2R68%(8&-G>6@B
MCFRTP*9]H!1I&3EWDEWX#JX-D*VM@F!TJBS^J$X$^!]O+-^+/[0NUVJU][S4
MRI?'.X*VB%&"!3#"3K,%*:SE(UA#]S^]X>AUNW?Q[J9+K1#+7?6'-]UVYVWW
MG&*W!UIF$X*W!J[SX,AJ-12W;V'/^<`*29X+A7?=?C?HGCP6BW?`D7<(!%SG
M2XHX&5!MV\IUHD=2$9`*\0JIRZBSGBGM>=HL(A<3&Q#,C8UKN>D.(('9OAB&
M^8K5V-^TFNPT&Y>C0+:L!Y.V[:M!"#U)/O=)`8JIW>3&MR\N^K]M&\\`K-;?
M)WB&?])*R/T\OA2-9\M:-F/(+.9ABQ9UAQ0$9'.40F$M2]1R[`Y9B.;*,SBI
M`K".,\?3C1P5#*.R+-8EW(5)0=Z^>_WZHFOLMU]B#/F&XP;YAA9$(<U][8G!
M4WW,^!>+FC%?*?ZE9O]1,/&!/_L$P:<P@XQYX,IB.4\OAIX4DJ!V)4E=S8M'
M-!;0U:`QDF.VM*U02P:K;P`#B*7<CBD!R:%!6F7,F6>I-^Q==F]`!7!;?Y&,
M5PS.+(;C:]P$>1=4LB@;BIYDO6H8[[9?9,)VL)3\=;AU-FR!R2/Z%D9PH/`X
M)VB++Q029="229T"O>GPW8NBA0,!5&GI8XE1NI3[E'<IV%2@&,Q4*@J-@;GJ
MQ(&'4;`.:[*.YZF3*%@]2R6_@`W3\"H?F*+H@[<HU3DFK%)S)2&%!Z2X3)[U
MKMY<=,5/!GYQH@6XMYNH5.(&"!4Y4G-&;,4@(,?@+^C<)HOZ-L/;"O*]AJ<8
MG+"O?OI=EK;1@K[1TK;#Y!`]==4,S@J46;502F?ZV23.T!E7!#L(M%,UX^3/
M^+D+@:0EJEJ!.!IN-6PZ\3@\MEK'.M5;);,DVV,EW<I4T?LDMWEE6)_6VKCX
MN;@'E#G#P;'8<9;LU[#S,:0JT\&>E!A-TK=_JG=)H[26,I?2=LA$H67NS&;!
MN*1&[J8%4H.`%%RE$EIW.':X"F(A_6!Y-Q5S.<=:'::O%+MC#CV18:0#DF3O
MMS-RTY-,R-*KMGCQ0CQ+JVWEW(0=Q_=A3@10TW!.\*59MFOZ-LU5[-D3AXJS
M7S*';2I."#!B2+E^`/_*XKFPZ_1/18CDM[[*#)"1.,PT\+2JK!REZ687I!I@
M!WH:#%@,!=8LY6*V(BP?G:W%KD988Y>?Y&:>L$&G1'\'KOKWBR\QHDRU_MOD
M1>DXF1?6Y%4C)_ML#^748--:EE+H3`:1R8A^[5V?:-?WS`@_RX_%L.3EF@WT
M<OO-M)ZU,=UZ).PGN<<APHWG"W1AD-*#VA3UOB02->+"19(:KHV:W3K)***L
M1=6(_5;3LNM;2..CN207!+Q^#K&<X,DB=,RD3UY63[,Y;]-.7A\^?2P5_^)C
MOQ^%%PF(BX(0(B,.F<!PM$I\!)^7A/K9//AKB!*:A'P6V!U>=%^K;&H+9CJ&
M_&K4-[TW;X=JYSLXP#);Y?"PE>@$[+(-&(<U>7;N?_CO:X[KAC40;@VF#WQ7
MU[FV`$Y".I;*5,PH<@'A-_!$XU8V&W$P+6T8#R!EBZ'1C;Z(YV!@<81_)GH+
MT&@V#[?6!A'!<R)X?FJN,\HL9L)\.:PWZ,CIJ'Y@-9DS6!O;$1`KLYGCT0.^
M4;E,';$M00H6_-R#$Z#=FTJ>X#%&T.E_@JU3)H50V-M<B$U*+U0'D4AB!AV+
M8)^]A3ETIR4&O3?MBYO+<CE-L#&`?+HWJG*HX:9G%NOVH,\;5.9=-NH8:9;N
MU-3AGE'\,(X,>3--SA43]Z8&I7L*_MG;I:-!0<H282(=B+$7CI<S)U2A!5;S
M*CIX4IB!=:(J<O-6U#Z21E2\^Y:-X(M;<F#)3DKR`ZCT\`K-)CL-"98:*6(R
MMF4>;:`KH"(`NOO0B[6[3T=:K"Y:G?.+,<*_AX1=BO\FX)G!D\V5DPJ-S1=/
M=+K$U2FZW3+ZY,D9G;Y4OD*O!-6807)L-PTL*%>.]I,])BUUW<GDW/%%''Y`
M;.Y'^(MVBF8Z,>J$R4'+2AW(L;*&1N1CMHC/GX6.29Z]2D]_4,9A,(=]/400
MI`.Z.^>C]F"$QWVCWA6>A;RYZ0X&$)/B&'0X:V!4<SUGXRL`[1@'I!D'Y*NE
M)*.`?+4TK9'N@PCX&%54F#G'>&Q3.;:3HXVO8\Y9NC*=WG!TS`,QO8DHO8']
M0.$"_K'OTP.TWN02(IB2,_4\G$?7XQ(X("HM@C[+5.R>--*@9!%$H&*!3R`G
MS^L-MX9_"!A6#8MFMZVBV<<7[0<"KP()9^5X,^=V)M.SEJ,Z)7;'C6/+UN7_
M)V>&HI"?6,L<[2OE=BFK>3^)8N`700V*P622GN.:O-+XS'`"\('S>QZ)TO/$
M'T+P+NZ=#W*YL,3S&?*G.7.IV0O<,DZ.V/@NA3JGM92/L\2V(#H9MS5.5L=]
M')4_0C.L,3VYO/U;AD'I102RB[R_93`I11'K7Q35,``&17^!OUHZ1V0/K>0T
M$\!P!Y=1-((4<^[@;H(AY4]HC)>#UZ/7_9O+]A"8"^\7O[35NS%#.@Y'=,][
M[5&G#7E._TWJ1]8.*=KG@W>_=-ZVKZZZ%WB7B6\:P#I2FZMD-![SUR=B$1DT
MAC+-I>LY8@PTSX([TB:.X8N6=D-J2=6S^ZD3UPA^I.!K\_&(PW-0-U(VSS?+
MSD\9"?Z.I,?<QN&SEE=8M+D^K'_A2BWU=O3/U_TT<?],=0B@/7FVUD3,8
M,`L.PU/#7-6@Y8_Z^ZP3H0CX$5C[O?("QXTZKM"N[Q\DUT+4Q18@;)1>FQ$Q
M$8P7EE;K2^-M/2;77JTF7A#T,TDGU,*36SM&<,KCC`!Y[OG+6%J\_6\#Y)#;
M$MM@R&%LP`51P?J4XG$(-=>7$-%T93/W65^_OM+T&-D8I6^;!Y.`,H<OHA#S
MCJK$A%$[!Y=I#VTWF.\8/8`L'2$Q;2%U:.VS.L!V;/,1?!+#5#*DJYMQ*K2B
M@#]I`<I0Z&:L2_<.5,QK1*H0;U=Y0#8.7C]?S23\#U@V1)I$>M=)H&GPS3/2
M?#ZK-Y49`,5*K?.0;E+8=C.]:OSHR2.ZKV&_T[T:WOP^P)S)",;R)X@96'60
MF%8+*/G/QF\/ZB[E\9&B"/+]X\UVB-[>V6:%IH/)"$M?^6-UP`B"'B+],"E;
MNM)%<*@<<Q(EPN`/Q%CD71RE4G,MT-'<;(Z2YLALGB3-*H?$6A_>]+#M`]MJ
M<5TC)RTJWD;+6U0*7\X$(4SOW$'/2'6-*,3AO;-BHD#CF0(:"!6F.)KN.(HY
MKA]#J(G)R^3.)ZB0)2!5#<=<G*:]38G0R`5+X?@Q17D+/WC[YL54*8IR@8_H
M"H,GY]:)>HSU*325R#'YFM8X,5:&6Q7KP;1*](BX_/W!DH_]9;&;1"#K-QC+
M:0@+.)*3\AQ1=*-+7RL>_-:^AGBC]+%,#O\G7;SX6#Z!_W+9-$8'1A;-G`&N
MIPFLD;/N<SI,E](\,A_A`4W'Q_#+=]%T@HD87B:4&$[3,SVF3CX1NOIJ(S@P
MU3:&J`QTE_,:3[VJ^ELV`=5%%T*.M&.&0BD*Y2@J'=Z%?08#MSF_<5$UBOB-
MM@X\W9CP.^0%24U`26!S?J:W`AUDIC&F"C%S$:9N&7%2KX!5&9;MLT%E1[MA
MIQ513:T9/^E,I1;*V:9"6+*F+X]*JF)F32Q?$=N.AHICQ'93(E\<HX:HT-(0
MF,@(3&0$QE]3V`=8EJW`/G)D';<4H^CH389AMM`LBL\C",!<N>+BB""]R1S7
M)/M:Q3@`XLV4KX.AI\."&6DB-TE_'+!3$([4?BS$>ZW2,[8(+J*?J?I6]I`H
MJ;#CK"4C7^J/?KOI7UW\GF9J#)DZ-7V&DM"KW%CVA@\NE*[\@M+VAOB-2NF%
MXU&7(VLZ/*GSNY>4^@T7JTM$C`6"Y.Y5!Z3D2%Y`D#IF0*A9@O4/'@#0_?/>
MU9O1X*)WU6W?C"ZZZ(D`=A'*,7]0A@<V!^SNF`A-&BU(OZ@C_R>3EGR;@2->
MJ9H2T^GQ@9_BI#Y/%-$2'"6DZNIX+UG,!"\S/U/\73\GR1^3K$O`\6I8EQ?(
ME,O^>9?<R"EWT-=OD3-?S.0H=&($:K5L/HW3W6J[Q3V^8;8;+`0.FCVI(!Z7
M@X+G+P#`$6E%>)3#@RYI$++82[BI-JNL4F;@OYEQ(F,M%+"QC::U4**.'`DO
MPZ)H1`?&^5Y$J^_ZJZCEGS1PP:_Y0OF_\)L:,T<B<SGGV\%@W/74Q8_+JDY9
M&\]=R`*1@1]_Z1IM-K;9XN5+EIMJ;6`K;5=G9Z+1@FP<QO'6HR":)@38QCI$
MRX0XV@"PCP#8O]9S0$.9(X_B/\P!;9KB"&$4R%KG<;+TELD0YE+:PON@K=F#
M4N$K`J4Q;A*CN)S&E]S-(Y(;`Q!4I<(%D$CZD<SLKKI1"VLR<^[0E`8=OE+8
M/E<=6',*EG%Z\KX+T43.(DBE!IU>O]/I7UZVK\XQSJ#8;&_7L`>J_8YK9`Y4
MY$U>L!Z''M!H:`J,D/A,80T%F$`41SB,Z>W_:L3"N:L6+X6=Q+QK%YU1O>E:
MT\0!M^B>"(7YN:NJED(5*I)).36AHL^XQC!)9)R_YJ&],QLL&[2QRVX4%VZZ
MZ@0+(D&*&#A1\-1746)WGCQ%R=.$$DR.`IK[ZCLXVPB6\/I6+!?5L\UQT7KW
MDP(@8PQ'.VD]V`AYLE"YHG&:=-KVOJ*\F5*.G-Y(N/5(+U<\\H0KEC]"=\;3
MKO4E1/8R7Z#;_S]?H-N/?H%N'V6^0+>/4DJ-+]#MS!?H#?ND7C_9/TJ^0`<D
MQA?H=O8+](,3^^BDU3"^0&_BMQ&5ICZ4KEVY^+7,PH&MP_6B,17@90@=@ZD8
M_'[5OQ[T!@@V5S/L5&K]A7@]$Q/1#C-7B`#*Z#';VND7.;5:C7&?=P>=F][U
ML->_XHL*!WQ/3->-:M>+'3&<2HA;9K/@'CD7+##RCH03RO1$X@1`?YF):NS<
MB>J]Y\93.A[!#;;6BY$<9XW0RF`!(<?DDXBG,M,#%BR6D:SM5-Y%,KV%K)-/
M2)+]2-]/`*#>1.!EJHBP>1(+B8!0^BLO#/PY9J$K)_20R@BHZ:Z$_FYMIP*\
MX";U5=I.Y=Z;S4#=!2J*"PFK#\B\2`0A>+XR$@;9LDL3,*VGP@%6B)D3X4>@
M41#&X.EJUXY(/UU+D<*B7&0\<R0C(),7^"U9&,SRW!"_!,!6YS8*9DN([19.
M/(6I@1I^PE2(;FC'`;N%`SH:L@\;ELUU[VOTXC0#AZ;!A*8"#D6*JLY<^>\=
M<>Y%]!4+$:2R>1(2^"$JEN/,7)=68VHL:\"A)07K\W<J0W0/P1;Y*1[C*S+O
M:LY1692,H+P7SSG9.'!FV(4!`(B;(W^R>N7@QW3)8.0.S-*&/6_0`T&*]K!]
MW8-=I'K3O\1+,!"G+2%8<T\)\9HRSI<1:#$XEP4(%X:I7G4,4Z(`6[S]6U#<
M3:[%P1*T?5"]]7`@?3G/O3(J(R6,'=>$-D3W`W!F/$8'8:"JWX7!<A&A@(`?
MS$5U8E;:%[>?@+2)LYS%%B['WK/W!?MV1*_EB/\'`Z;(\2,\1)B8K'8&ANQ!
-@66\\W\68PX1,40``)S%
`
end
>Unformatted: