Subject: Re: toolchain/34551: Makefile.disklabel does too much find(1).
To: None <gnats-bugs@NetBSD.org>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: netbsd-bugs
Date: 11/25/2006 22:33:00
>  yamt@mwd.biglobe.ne.jp wrote:
>  
>  > 	during "build.sh tools", tools/Makefile.disklabel seems to
>  > 	perform find(1) on sys/arch several times.
>  
>  ---
>  
>  _ARCHDIR=	${.CURDIR}/../../sys/arch
>   :
>  _UFSDIR=	${.CURDIR}/../../sys/ufs
>   :
>  _UFS_INCS!=	cd ${_UFSDIR} && find ffs ufs -name '*.h'
>  _ARCH_INCS!=	cd ${_ARCHDIR} && find . -name disklabel.h
>  
>  ---
>  The problem would be searching all files even in arch/*/compile dir?
>  Is it okay to search only arch/*/include dirs?
>  
>  _ARCH_INCS!=	cd ${_ARCHDIR} && find */include -name disklabel.h
>  
>  Or echo(1) is enough?
>  
>  _UFS_INCS!=	cd ${_UFSDIR} && echo ffs/*.h ufs/*.h
>  _ARCH_INCS!=	cd ${_ARCHDIR} && echo */include/disklabel.h
>  
>  ---
>  Izumi Tsutsui

i don't think running find or something like it during a build is
a right thing at all.
it's better to have a static list of files, IMO.

YAMAMOTO Takashi