Subject: kern/35442: double assignment in uvm_pdpolicy_clock.c
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Andreas Wiese <aw-netbsd@instandbesetzt.net>
List: netbsd-bugs
Date: 01/19/2007 00:05:00
>Number:         35442
>Category:       kern
>Synopsis:       someone forgot editing a line in uvm_pdpolicy_clock.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 19 00:05:00 +0000 2007
>Originator:     Andreas Wiese
>Release:        NetBSD 4.99.8
>Organization:
	BSD Crew Dresden
>Environment:
System: NetBSD schroeder.lan.instandbesetzt.net 4.99.8 NetBSD 4.99.8 (SCHROEDER) #0: Thu Jan 11 21:37:15 CET 2007 root@schroeder.lan.instandbesetzt.net:/usr/obj/sys/arch/i386/compile/SCHROEDER i386
Architecture: i386
Machine: i386
>Description:
In src/sys/uvm/uvm_pdpolicy_clock.c we have this:

   130		s->s_inactarg = 
   131		s->s_inactarg = UVM_PCTPARAM_APPLY(&s->s_inactivepct,
   132		    s->s_active + s->s_inactive);

>How-To-Repeat:
n/a
>Fix:
--- sys/uvm/uvm_pdpolicy_clock.c.old	2007-01-19 01:02:57.000000000 +0100
+++ sys/uvm/uvm_pdpolicy_clock.c	2007-01-19 01:03:07.000000000 +0100
@@ -127,7 +127,6 @@
 {
 	struct uvmpdpol_globalstate *s = &pdpol_state;
 
-	s->s_inactarg = 
 	s->s_inactarg = UVM_PCTPARAM_APPLY(&s->s_inactivepct,
 	    s->s_active + s->s_inactive);
 	if (s->s_inactarg <= uvmexp.freetarg) {

HAND & LG -- aw
np: Linkin Park ([REANIMATION]) -- 11. WTH>YOU
-- 
Unnützes Wissen (»neon«, 11/04):
  9. Brad Pitt reagiert allergisch auf Hundehaare.