Subject: Re: kern/34071: azalia device driver doesn't support pin sensing
To: None <kent@NetBSD.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,>
From: TAMURA Kent <kent@NetBSD.org>
List: netbsd-bugs
Date: 05/08/2007 02:25:02
The following reply was made to PR kern/34071; it has been noted by GNATS.
From: "TAMURA Kent" <kent@NetBSD.org>
To: gnats-bugs@netbsd.org, wulf@netbsd.org, simonb@netbsd.org
Cc:
Subject: Re: kern/34071: azalia device driver doesn't support pin sensing
Date: Mon, 7 May 2007 19:21:43 -0700
------=_Part_52357_5199710.1178590903578
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Would you test the attached patch please?
--
TAMURA Kent <kent_2007 at hauN.org> <kent at NetBSD.org>
------=_Part_52357_5199710.1178590903578
Content-Type: application/octet-stream; name=azalia_codec.diff
Content-Transfer-Encoding: base64
X-Attachment-Id: f_f1fqgaoj
Content-Disposition: attachment; filename="azalia_codec.diff"
SW5kZXg6IGF6YWxpYV9jb2RlYy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3NyYy9z
eXMvZGV2L3BjaS9hemFsaWFfY29kZWMuYyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zNgpkaWZm
IC11IC1yMS4zNiBhemFsaWFfY29kZWMuYwotLS0gYXphbGlhX2NvZGVjLmMJMTkgTWFyIDIwMDcg
MTY6Mjc6MDAgLTAwMDAJMS4zNgorKysgYXphbGlhX2NvZGVjLmMJOCBNYXkgMjAwNyAwMjoxNjo1
MSAtMDAwMApAQCAtOTUsNiArOTUsNyBAQAogc3RhdGljIGludAlnZW5lcmljX21peGVyX2Vuc3Vy
ZV9jYXBhY2l0eShjb2RlY190ICosIHNpemVfdCk7CiBzdGF0aWMgaW50CWdlbmVyaWNfbWl4ZXJf
Z2V0KGNvbnN0IGNvZGVjX3QgKiwgbmlkX3QsIGludCwgbWl4ZXJfY3RybF90ICopOwogc3RhdGlj
IGludAlnZW5lcmljX21peGVyX3NldChjb2RlY190ICosIG5pZF90LCBpbnQsIGNvbnN0IG1peGVy
X2N0cmxfdCAqKTsKK3N0YXRpYyBpbnQJZ2VuZXJpY19taXhlcl9waW5jdHJsKGNvZGVjX3QgKiwg
bmlkX3QsIHVpbnQzMl90KTsKIHN0YXRpYyB1X2NoYXIJZ2VuZXJpY19taXhlcl9mcm9tX2Rldmlj
ZV92YWx1ZQogCShjb25zdCBjb2RlY190ICosIG5pZF90LCBpbnQsIHVpbnQzMl90ICk7CiBzdGF0
aWMgdWludDMyX3QJZ2VuZXJpY19taXhlcl90b19kZXZpY2VfdmFsdWUKQEAgLTEzMCw4ICsxMzEs
NiBAQAogc3RhdGljIGludAlzdGFjOTIyMV9taXhlcl9pbml0KGNvZGVjX3QgKik7CiBzdGF0aWMg
aW50CXN0YWM5MjIxX2dwaW9fdW5tdXRlKGNvZGVjX3QgKiwgaW50KTsKIHN0YXRpYyBpbnQJc3Rh
YzkyMjBfbWl4ZXJfaW5pdChjb2RlY190ICopOwotc3RhdGljIGludAlzdGFjOTIyMF9zZXRfcG9y
dChjb2RlY190ICosIG1peGVyX2N0cmxfdCAqKTsKLXN0YXRpYyBpbnQJc3RhYzkyMjBfZ2V0X3Bv
cnQoY29kZWNfdCAqLCBtaXhlcl9jdHJsX3QgKik7CiBzdGF0aWMgaW50CXN0YWM5MjIwX3Vuc29s
X2V2ZW50KGNvZGVjX3QgKiwgaW50KTsKIAogCkBAIC0yMzYsNyArMjM1LDYgQEAKIAljYXNlIDB4
ODM4NDc2OTA6CiAJCXRoaXMtPm5hbWUgPSAiU2lnbWF0ZWwgU1RBQzkyMjAiOwogCQl0aGlzLT5t
aXhlcl9pbml0ID0gc3RhYzkyMjBfbWl4ZXJfaW5pdDsKLQkJdGhpcy0+c2V0X3BvcnQgPSBzdGFj
OTIyMF9zZXRfcG9ydDsKIAkJdGhpcy0+dW5zb2xfZXZlbnQgPSBzdGFjOTIyMF91bnNvbF9ldmVu
dDsKIAkJZXh0cmFfc2l6ZSA9IDE7CiAJCWJyZWFrOwpAQCAtMTM2OSwyMSArMTM2NywxMiBAQAog
CWVsc2UgaWYgKHRhcmdldCA9PSBNSV9UQVJHRVRfUElORElSKSB7CiAJCWlmIChtYy0+dW4ub3Jk
ID49IDIpCiAJCQlyZXR1cm4gRUlOVkFMOwotCQllcnIgPSB0aGlzLT5jb21yZXNwKHRoaXMsIG5p
ZCwKLQkJICAgIENPUkJfR0VUX1BJTl9XSURHRVRfQ09OVFJPTCwgMCwgJnJlc3VsdCk7Ci0JCWlm
IChlcnIpCi0JCQlyZXR1cm4gZXJyOwogCQlpZiAobWMtPnVuLm9yZCA9PSAwKSB7Ci0JCQlyZXN1
bHQgJj0gfkNPUkJfUFdDX09VVFBVVDsKLQkJCXJlc3VsdCB8PSBDT1JCX1BXQ19JTlBVVDsKKwkJ
CXJldHVybiBnZW5lcmljX21peGVyX3BpbmN0cmwodGhpcywgbmlkLCBDT1JCX1BXQ19JTlBVVCk7
CiAJCX0gZWxzZSB7Ci0JCQlyZXN1bHQgJj0gfkNPUkJfUFdDX0lOUFVUOwotCQkJcmVzdWx0IHw9
IENPUkJfUFdDX09VVFBVVDsKKwkJCXJldHVybiBnZW5lcmljX21peGVyX3BpbmN0cmwoCisJCQkg
ICAgdGhpcywgbmlkLCBDT1JCX1BXQ19PVVRQVVQpOwogCQl9Ci0JCWVyciA9IHRoaXMtPmNvbXJl
c3AodGhpcywgbmlkLAotCQkgICAgQ09SQl9TRVRfUElOX1dJREdFVF9DT05UUk9MLCByZXN1bHQs
ICZyZXN1bHQpOwotCQlpZiAoZXJyKQotCQkJcmV0dXJuIGVycjsKIAl9CiAKIAkvKiBwaW4gaGVh
ZHBob25lLWJvb3N0ICovCkBAIC0xNTI5LDYgKzE1MTgsMjEgQEAKIAlyZXR1cm4gMDsKIH0KIAor
c3RhdGljIGludAorZ2VuZXJpY19taXhlcl9waW5jdHJsKGNvZGVjX3QgKnRoaXMsIG5pZF90IG5p
ZCwgdWludDMyX3QgdmFsdWUpCit7CisJaW50IGVycjsKKwl1aW50MzJfdCByZXN1bHQ7CisKKwll
cnIgPSB0aGlzLT5jb21yZXNwKHRoaXMsIG5pZCwgQ09SQl9HRVRfUElOX1dJREdFVF9DT05UUk9M
LCAwLCAmcmVzdWx0KTsKKwlpZiAoZXJyKQorCQlyZXR1cm4gZXJyOworCXJlc3VsdCAmPSB+KENP
UkJfUFdDX09VVFBVVCB8IENPUkJfUFdDX0lOUFVUKTsKKwlyZXN1bHQgfD0gdmFsdWUgJiAoQ09S
Ql9QV0NfT1VUUFVUIHwgQ09SQl9QV0NfSU5QVVQpOworCXJldHVybiB0aGlzLT5jb21yZXNwKHRo
aXMsIG5pZCwKKwkgICAgQ09SQl9TRVRfUElOX1dJREdFVF9DT05UUk9MLCByZXN1bHQsIE5VTEwp
OworfQorCiBzdGF0aWMgdV9jaGFyCiBnZW5lcmljX21peGVyX2Zyb21fZGV2aWNlX3ZhbHVlKGNv
bnN0IGNvZGVjX3QgKnRoaXMsIG5pZF90IG5pZCwgaW50IHRhcmdldCwKICAgICB1aW50MzJfdCBk
dikKQEAgLTI5NjcsOSArMjk3MSw5IEBACiAjZGVmaW5lIFNUQUM5MjIwX0RFTExfNjQwTV9JRAkJ
MHgwMWQ4MTAyOAogI2RlZmluZSBTVEFDOTIyMF9FVkVOVF9IUAkwCiAjZGVmaW5lIFNUQUM5MjIw
X0VYVFJBX01BU1RFUgkwCi0jZGVmaW5lIFNUQUM5MjIwX05JRF9NQVNURVIJMHgwYgogI2RlZmlu
ZSBTVEFDOTIyMF9OSURfSFAJCTB4MGQKLQlpZiAoZmFsc2UgJiYgKHRoaXMtPnN1YmlkID09IFNU
QUM5MjIwX0RFTExfSU5TUElST045NDAwX0lEIHx8CisjZGVmaW5lIFNUQUM5MjIwX05JRF9TUEVB
S0VSCTB4MGUKKwlpZiAodHJ1ZSAmJiAodGhpcy0+c3ViaWQgPT0gU1RBQzkyMjBfREVMTF9JTlNQ
SVJPTjk0MDBfSUQgfHwKIAkJICAgICAgdGhpcy0+c3ViaWQgPT0gU1RBQzkyMjBfREVMTF82NDBN
X0lEKSkgewogCQkvKiBzZXR1cCBhIHVuc29saWNpdGVkIGV2ZW50IGZvciB0aGUgaGVhZHBob25l
cyAqLwogCQl0aGlzLT5jb21yZXNwKHRoaXMsIFNUQUM5MjIwX05JRF9IUCwgQ09SQl9TRVRfVU5T
T0xJQ0lURURfUkVTUE9OU0UsCkBAIC0yOTc3LDY1ICsyOTgxLDEzIEBACiAJCXRoaXMtPmV4dHJh
W1NUQUM5MjIwX0VYVFJBX01BU1RFUl0gPSAwOyAvKiB1bm11dGUgKi8KIAkJLyogSWYgdGhlIGhl
YWRwaG9uZSBwcmVzZW50cywgbXV0ZSB0aGUgaW50ZXJuYWwgc3BlYWtlciAqLwogCQl0aGlzLT5j
b21yZXNwKHRoaXMsIFNUQUM5MjIwX05JRF9IUCwgQ09SQl9HRVRfUElOX1NFTlNFLCAwLCAmdmFs
dWUpOwotCQltYy51bi5vcmQgPSB2YWx1ZSAmIENPUkJfUFNfUFJFU0VOU0UgPyAxIDogMDsKLQkJ
Z2VuZXJpY19taXhlcl9zZXQodGhpcywgU1RBQzkyMjBfTklEX01BU1RFUiwgTUlfVEFSR0VUX09V
VEFNUCwgJm1jKTsKLQkJdGhpcy0+Z2V0X3BvcnQgPSBzdGFjOTIyMF9nZXRfcG9ydDsKLQl9Ci0J
cmV0dXJuIDA7Ci19Ci0KLXN0YXRpYyBpbnQKLXN0YWM5MjIwX3NldF9wb3J0KGNvZGVjX3QgKnRo
aXMsIG1peGVyX2N0cmxfdCAqbWMpCi17Ci0JY29uc3QgbWl4ZXJfaXRlbV90ICptOwotCXVpbnQz
Ml90IHZhbHVlOwotCWludCBlcnI7Ci0KLQlpZiAobWMtPmRldiA+PSB0aGlzLT5ubWl4ZXJzKQot
CQlyZXR1cm4gRU5YSU87Ci0JbSA9ICZ0aGlzLT5taXhlcnNbbWMtPmRldl07Ci0JaWYgKG1jLT50
eXBlICE9IG0tPmRldmluZm8udHlwZSkKLQkJcmV0dXJuIEVJTlZBTDsKLQlpZiAobWMtPnR5cGUg
PT0gQVVESU9fTUlYRVJfQ0xBU1MpCi0JCXJldHVybiAwOwotCWlmICgodGhpcy0+c3ViaWQgPT0g
U1RBQzkyMjBfREVMTF9JTlNQSVJPTjk0MDBfSUQgfHwKLQkgICAgIHRoaXMtPnN1YmlkID09IFNU
QUM5MjIwX0RFTExfNjQwTV9JRCkgJiYKLQkgICAgbS0+bmlkID09IFNUQUM5MjIwX05JRF9NQVNU
RVIgJiYKLQkgICAgbS0+dGFyZ2V0ID09IE1JX1RBUkdFVF9PVVRBTVAgJiYgbWMtPnR5cGUgPT0g
QVVESU9fTUlYRVJfRU5VTSkgewotCQlpZiAobWMtPnVuLm9yZCAhPSAwICYmIG1jLT51bi5vcmQg
IT0gMSkKLQkJCXJldHVybiBFSU5WQUw7Ci0JCXRoaXMtPmV4dHJhW1NUQUM5MjIwX0VYVFJBX01B
U1RFUl0gPSBtYy0+dW4ub3JkOwotCQllcnIgPSB0aGlzLT5jb21yZXNwKHRoaXMsIFNUQUM5MjIw
X05JRF9IUCwKLQkJICAgIENPUkJfR0VUX1BJTl9TRU5TRSwgMCwgJnZhbHVlKTsKLQkJaWYgKGVy
cikKLQkJCXJldHVybiBlcnI7Ci0JCWlmICghKHZhbHVlICYgQ09SQl9QU19QUkVTRU5TRSkpIHsK
LQkJCXJldHVybiBnZW5lcmljX21peGVyX3NldCh0aGlzLCBtLT5uaWQsIG0tPnRhcmdldCwgbWMp
OworCQlpZiAodmFsdWUgJiBDT1JCX1BTX1BSRVNFTlNFKSB7CisJCQlnZW5lcmljX21peGVyX3Bp
bmN0cmwodGhpcywgU1RBQzkyMjBfTklEX1NQRUFLRVIsIDApOworCQl9IGVsc2UgeworCQkJZ2Vu
ZXJpY19taXhlcl9waW5jdHJsKHRoaXMsIFNUQUM5MjIwX05JRF9TUEVBS0VSLCBDT1JCX1BXQ19P
VVRQVVQpOwogCQl9Ci0JCXJldHVybiAwOwotCX0KLQlyZXR1cm4gZ2VuZXJpY19taXhlcl9zZXQo
dGhpcywgbS0+bmlkLCBtLT50YXJnZXQsIG1jKTsKLX0KLQotc3RhdGljIGludAotc3RhYzkyMjBf
Z2V0X3BvcnQoY29kZWNfdCAqdGhpcywgbWl4ZXJfY3RybF90ICptYykKLXsKLQljb25zdCBtaXhl
cl9pdGVtX3QgKm07Ci0KLQlpZiAobWMtPmRldiA+PSB0aGlzLT5ubWl4ZXJzKQotCQlyZXR1cm4g
RU5YSU87Ci0JbSA9ICZ0aGlzLT5taXhlcnNbbWMtPmRldl07Ci0JbWMtPnR5cGUgPSBtLT5kZXZp
bmZvLnR5cGU7Ci0JaWYgKG1jLT50eXBlID09IEFVRElPX01JWEVSX0NMQVNTKQotCQlyZXR1cm4g
MDsKLQlpZiAoKHRoaXMtPnN1YmlkID09IFNUQUM5MjIwX0RFTExfSU5TUElST045NDAwX0lEIHx8
Ci0JICAgICB0aGlzLT5zdWJpZCA9PSBTVEFDOTIyMF9ERUxMXzY0ME1fSUQpICYmCi0JICAgIG0t
Pm5pZCA9PSBTVEFDOTIyMF9OSURfTUFTVEVSICYmCi0JICAgIG0tPnRhcmdldCA9PSBNSV9UQVJH
RVRfT1VUQU1QICYmIG1jLT50eXBlID09IEFVRElPX01JWEVSX0VOVU0pIHsKLQkJbWMtPnVuLm9y
ZCA9IHRoaXMtPmV4dHJhW1NUQUM5MjIwX0VYVFJBX01BU1RFUl07Ci0JCXJldHVybiAwOwogCX0K
LQlyZXR1cm4gZ2VuZXJpY19taXhlcl9nZXQodGhpcywgbS0+bmlkLCBtLT50YXJnZXQsIG1jKTsK
KwlyZXR1cm4gMDsKIH0KIAogc3RhdGljIGludApAQCAtMzA0Myw3ICsyOTk1LDYgQEAKIHsKIAlp
bnQgZXJyOwogCXVpbnQzMl90IHZhbHVlOwotCW1peGVyX2N0cmxfdCBtYzsKIAogCXN3aXRjaCAo
dGFnKSB7CiAJY2FzZSBTVEFDOTIyMF9FVkVOVF9IUDoKQEAgLTMwNTEsMTggKzMwMDIsMTIgQEAK
IAkJICAgIENPUkJfR0VUX1BJTl9TRU5TRSwgMCwgJnZhbHVlKTsKIAkJaWYgKGVycikKIAkJCWJy
ZWFrOwotCQltYy5kZXYgPSAtMTsKLQkJbWMudHlwZSA9IEFVRElPX01JWEVSX0VOVU07CiAJCWlm
ICh2YWx1ZSAmIENPUkJfUFNfUFJFU0VOU0UpIHsKIAkJCURQUklOVEYoKCIlczogaGVhZHBob25l
IGhhcyBiZWVuIGluc2VydGVkLlxuIiwgX19mdW5jX18pKTsKLQkJCW1jLnVuLm9yZCA9IDE7IC8q
IG11dGUgKi8KLQkJCWdlbmVyaWNfbWl4ZXJfc2V0KHRoaXMsIFNUQUM5MjIwX05JRF9NQVNURVIs
Ci0JCQkgICAgTUlfVEFSR0VUX09VVEFNUCwgJm1jKTsKKwkJCWdlbmVyaWNfbWl4ZXJfcGluY3Ry
bCh0aGlzLCBTVEFDOTIyMF9OSURfU1BFQUtFUiwgMCk7CiAJCX0gZWxzZSB7CiAJCQlEUFJJTlRG
KCgiJXM6IGhlYWRwaG9uZSBoYXMgYmVlbiBwdWxsZWQgb3V0LlxuIiwgX19mdW5jX18pKTsKLQkJ
CW1jLnVuLm9yZCA9IHRoaXMtPmV4dHJhW0FMQzI2MF9FWFRSQV9NQVNURVJdOwotCQkJZ2VuZXJp
Y19taXhlcl9zZXQodGhpcywgU1RBQzkyMjBfTklEX01BU1RFUiwKLQkJCSAgICBNSV9UQVJHRVRf
T1VUQU1QLCAmbWMpOworCQkJZ2VuZXJpY19taXhlcl9waW5jdHJsKHRoaXMsIFNUQUM5MjIwX05J
RF9TUEVBS0VSLCBDT1JCX1BXQ19PVVRQVVQpOwogCQl9CiAJCWJyZWFrOwogCWRlZmF1bHQ6Cg==
------=_Part_52357_5199710.1178590903578--