Subject: Re: kern/35128 (USB host controller resume fails on ThinkPad X32)
To: None <kern-bug-people@netbsd.org, gnats-admin@netbsd.org,>
From: Thomas Klausner <wiz@netbsd.org>
List: netbsd-bugs
Date: 08/03/2007 21:05:03
The following reply was made to PR kern/35128; it has been noted by GNATS.
From: Thomas Klausner <wiz@netbsd.org>
To: "Jared D. McNeill" <jmcneill@invisible.ca>
Cc: gnats-bugs@NetBSD.org
Subject: Re: kern/35128 (USB host controller resume fails on ThinkPad X32)
Date: Fri, 3 Aug 2007 23:01:53 +0200
On Fri, Aug 03, 2007 at 07:49:16AM -0400, Jared D. McNeill wrote:
> wiz@netbsd.org wrote:
> >>Log Message:
> >>Establish powerhooks in the proper order. From Anon Ymous
> >says submitter.
>
> I say so also. Why do you believe this fix to be incorrect?
>
> The original behaviour was badly broken -- after you transition the
> device to D3 on suspend, you can't expect writing any UHCI registers to
> work. Likewise, we need to transition to D0 on resume before restoring
> UHCI registers -- if the previous code worked for anybody, it was a fluke.
Sorry if the wording was confusing -- it was not meant to be in
disagreement.
I wanted to say something like: Submitter says "close the PR, this
fixed it".
Cheers,
Thomas